Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.9.0 introduces TypeScript issues when building using the vue cli #6360

Closed
shandrolis opened this issue Feb 12, 2020 · 2 comments · Fixed by #6373
Closed

Version 1.9.0 introduces TypeScript issues when building using the vue cli #6360

shandrolis opened this issue Feb 12, 2020 · 2 comments · Fixed by #6373
Assignees
Labels
bug

Comments

@shandrolis
Copy link

@shandrolis shandrolis commented Feb 12, 2020

If you try to build a project that was created with the Vue-cli (using the quasar plugin) with the new quasar 1.9.0 version, the build will fail with errors. Reverting to an older version of quasar gets rid of these errors.

ERROR in <project-root>/node_modules/quasar/dist/types/configuration/electron-conf.d.ts(21,8):
21:8 Cannot find module 'electron-packager'.
ERROR in <project-root>/node_modules/quasar/dist/types/globals.d.ts(4,26):
4:26 Cannot find module 'cordova'.

The above two errors disappear when adding a shims.d.ts file declaring these in our /src.

However, when building the project on our TeamCity agents, we get two additional errors, namely:

ERROR in /opt/buildagent/work/3b861d5a47df892a/<project-root>/node_modules/quasar/dist/types/configuration/build.d.ts(102,33):
[16:32:10]    [Step 2/7] 102:33 Property 'devtool' does not exist on type 'WebpackConfiguration'.
ERROR in /opt/buildagent/work/3b861d5a47df892a/<project-root>/node_modules/webpack-chain/types/index.d.ts(3,24):
[16:32:10]    [Step 2/7] 3:24 Cannot find module 'https'

Adding the above two to a shims file does not fix them however.
We are unsure how webpack-chain is related to this whole thing, but hoping you might know. :D

Our building agents are running npm version 6.13.7 (which is the newest available)

@IlCallo

This comment has been minimized.

Copy link
Collaborator

@IlCallo IlCallo commented Feb 12, 2020

We're on it, thanks for the issue

rstoenescu added a commit that referenced this issue Feb 14, 2020
fix(typescript): move Quasar CLI related typings to @quasar/app, fix: #6360
@rstoenescu

This comment has been minimized.

Copy link
Member

@rstoenescu rstoenescu commented Feb 14, 2020

Fix will be available in "quasar" v1.9.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.