Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QSelect opens if it was clicked while it was readonly after it's editable again #7323

Closed
vilyus opened this issue Jun 29, 2020 · 1 comment
Closed

QSelect opens if it was clicked while it was readonly after it's editable again #7323

vilyus opened this issue Jun 29, 2020 · 1 comment
Assignees
@pdanpdan
Labels
has PR 💯 kind/bug 🐞

Comments

@vilyus
Copy link

vilyus commented Jun 29, 2020

Describe the bug
If QSelect gets :readonly="false" and it was already clicked while it was readonly it opens immediately. This behaviour happens only with behavior="dialog"

Codepen/jsFiddle/Codesandbox (required)
https://codepen.io/Vilyus/pen/KKVXRNP

To Reproduce
Steps to reproduce the behavior:

  1. Click readonly QSelect with behavior="dialog"
  2. Make it editable again
  3. Dialog shows up immediately

Expected behavior
QSelect stays closed

Platform (please complete the following information):
OS: Linux Mint 19.3 Tricia
Node:
NPM:
Yarn:
Browsers: FF, Chromium
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jun 29, 2020
@pdanpdan
fix(QSelect): exit showPopup if it's not editable quasarframework#7323
5ba56ec
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jun 29, 2020
@pdanpdan
fix(QSelect): exit showPopup if it's not editable quasarframework#7323
166d62d
@pdanpdan pdanpdan self-assigned this Jul 5, 2020
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jul 5, 2020
@pdanpdan
fix(QSelect): exit showPopup if it's not editable quasarframework#7323
5771bc4
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jul 8, 2020
@pdanpdan
fix(QSelect): exit showPopup if it's not editable quasarframework#7323
e5825fd
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jul 8, 2020
@pdanpdan
fix(QSelect): exit showPopup if it's not editable quasarframework#7323
242afcf
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jul 9, 2020
@pdanpdan
fix(QSelect): exit showPopup if it's not editable quasarframework#7323
2b013c3
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jul 9, 2020
@pdanpdan
fix(QSelect): exit showPopup if it's not editable quasarframework#7323
df1ac97
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jul 9, 2020
@pdanpdan
fix(QSelect): exit showPopup if it's not editable quasarframework#7323
9a822d7
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jul 10, 2020
@pdanpdan
fix(QSelect): exit showPopup if it's not editable quasarframework#7323
5f6af41
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jul 10, 2020
@pdanpdan
fix(QSelect): exit showPopup if it's not editable quasarframework#7323
b08a565
webnoob pushed a commit that referenced this issue Jul 10, 2020
@pdanpdan
fix(QSelect): exit showPopup if it's not editable #7323 (#7325)
fd8d41b
@webnoob
Copy link
Contributor

webnoob commented Jul 10, 2020

Fix available in 1.12.9

@webnoob webnoob closed this as completed Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pdanpdan pdanpdan

Labels
has PR 💯 kind/bug 🐞
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pdanpdan @vilyus @webnoob