Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #3229 quasar cli command "quasar c" conflicts #3235

Merged
merged 3 commits into from Feb 13, 2019

Conversation

Projects
None yet
2 participants
@superoo7
Copy link
Contributor

superoo7 commented Feb 13, 2019

Refer to #3229

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@superoo7 superoo7 changed the title fix(cli): quasar cli command "quasar c" conflict with clean and creat… fix: #3229 quasar cli command "quasar c" conflicts Feb 13, 2019

superoo7 and others added some commits Feb 13, 2019

@rstoenescu rstoenescu merged commit 880f76c into quasarframework:dev Feb 13, 2019

@rstoenescu

This comment has been minimized.

Copy link
Member

rstoenescu commented Feb 13, 2019

Thank you for taking time for a PR on this!

@rstoenescu

This comment has been minimized.

Copy link
Member

rstoenescu commented Feb 13, 2019

Released @quasar/cli v1.0.0-beta.1, containing the PR.

@superoo7

This comment has been minimized.

Copy link
Contributor Author

superoo7 commented Feb 13, 2019

All good, thanks for shipping that.

@rstoenescu

This comment has been minimized.

Copy link
Member

rstoenescu commented Feb 13, 2019

Thanks for reporting and especially for taking time for a fix! This helps a LOT as we're currently dealing with way too many things in parallel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.