Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in QUploaderBase #4166

Merged
merged 1 commit into from May 21, 2019
Merged

Fix in QUploaderBase #4166

merged 1 commit into from May 21, 2019

Conversation

nachodd
Copy link
Contributor

@nachodd nachodd commented May 21, 2019

When $refs.input is not setted, __geFileInput returns this.$el.getElementsByClassName and that is an array. So, for instance when pickFiles method is called, it breaks when input.click() is fired

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

When $refs.input is not setted, __geFileInput returns this.$el.getElementsByClassName and that is an array. So, for instance when pickFiles method is called, it breaks when input.click() is fired
@rstoenescu rstoenescu merged commit 992a422 into quasarframework:dev May 21, 2019
@rstoenescu
Copy link
Member

Thank you for taking time for a PR! Much appreciate it.
This will get into rc.1.

@nachodd
Copy link
Contributor Author

nachodd commented May 21, 2019

Glad to help this awesome framework!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants