Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QSelect - Add q-toggle to the options #5046

Merged
merged 6 commits into from Sep 8, 2019

Conversation

@edgar-koster
Copy link
Contributor

commented Sep 7, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
This is an extra example to QSelect to add QToggle to the option list. Some like this feature as it is even more clear it is a selected value. Codepen can be found here

edgar-koster and others added 6 commits Sep 7, 2019
Example for Options with q-toggle in the display
This is an example to show how you can implement `q-toggle` in the options. See a working example here: https://codepen.io/ekoster/pen/gOYoqJP?&editable=true&editors=101

@rstoenescu rstoenescu merged commit 826daad into quasarframework:dev Sep 8, 2019

@rstoenescu

This comment has been minimized.

Copy link
Member

commented Sep 8, 2019

Thx for contributing!

rstoenescu added a commit that referenced this pull request Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.