Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(QTable): support for nested row key #5391

Merged
merged 1 commit into from Oct 25, 2019

Conversation

@stefanvanherwijnen
Copy link
Contributor

stefanvanherwijnen commented Oct 24, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Other information:
Currently, only a string can be used for the row-key. In some cases the key (ID) is nested inside an object (https://github.com/mrichar1/jsonapi-vuex). This PR provides the ability to use a nested row key similar to the field property of a column.

@rstoenescu rstoenescu merged commit e2585ad into quasarframework:dev Oct 25, 2019
@rstoenescu

This comment has been minimized.

Copy link
Member

rstoenescu commented Oct 25, 2019

Thank you for contributing!
This will get into "quasar" v1.2.6.

@rstoenescu

This comment has been minimized.

Copy link
Member

rstoenescu commented Oct 25, 2019

Will make some small adjustments though.

@stefanvanherwijnen

This comment has been minimized.

Copy link
Contributor Author

stefanvanherwijnen commented Oct 25, 2019

Thanks, using a computed property looks much better indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.