Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app/cordova): fixed possible race condition #5750

Conversation

@yusufkandemir
Copy link
Contributor

yusufkandemir commented Nov 29, 2019

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • It's been tested on a Cordova (iOS, Android) app

Other information:
Previously it was async and wasn't awaited, so a possible race condition could produce a bug, solved by making it sync since the containing function is sync.
Documentation for ensureDirSync

@rstoenescu rstoenescu merged commit f5add4d into quasarframework:dev Nov 29, 2019
@rstoenescu

This comment has been minimized.

Copy link
Member

rstoenescu commented Nov 29, 2019

Nice find!

@yusufkandemir yusufkandemir deleted the yusufkandemir:fix(app)-race-condition-cordova-platform branch Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.