Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new instructions for windows users #5973

Merged
merged 1 commit into from Dec 30, 2019
Merged

Conversation

@gregveres
Copy link
Contributor

gregveres commented Dec 30, 2019

The instructions for windows users were not correct given the state of things in December 2019. In addition to the software listed on this page to install, I had to install the JDK separately and gradle separately. And Cordova has moved on and now requires android-28 SDK to be installed or it wont work.

I have followed the new instructions in this PR and tested that it worked properly. I pass the cordova requirements check.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • [X ] Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • [X ] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [X ] It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • [ X] It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • [ X] Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
just a documentation fix based on my experience as a new Quasar user trying to get cordova up and running on android using Windows 10. The currently documented method doesn't work anymore so I am updating the doc to allow others to find working documentation. BTW, I looked at the Discord server and saw others were running into the same problems I did.

The instructions for windows users were not correct given the state of things in December 2019. In addition to the software listed on this page to install, I had to install the JDK separately and gradle separately. And Cordova has moved on and now requires android-28 SDK to be installed or it wont work. 

I have followed the new instructions in this PR and tested that it worked properly. I pass the cordova requirements check.
@rstoenescu rstoenescu merged commit fda413e into quasarframework:dev Dec 30, 2019
@rstoenescu

This comment has been minimized.

Copy link
Member

rstoenescu commented Dec 30, 2019

Hi,

Thanks for taking time for this docs PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.