Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QBanner avatar set aligned to top #6625

Merged
merged 2 commits into from Mar 22, 2020
Merged

Conversation

@onurkose
Copy link
Contributor

onurkose commented Mar 16, 2020

https://codepen.io/onurkose/pen/jOPxpyB?editable=true&editors=101

It usually centers itself when multiline messages used. I propose to add avatar-align prop to QBanner and there'll be option to align the QAvatar to middle or top.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

onurkose and others added 2 commits Mar 16, 2020
https://codepen.io/onurkose/pen/jOPxpyB?editable=true&editors=101

It usually centers itself when multiline messages used.  I propose to add avatar-align prop to QBanner and there'll be option to align the QAvatar to middle or top.
@rstoenescu

This comment has been minimized.

Copy link
Member

rstoenescu commented Mar 22, 2020

Hi,

Thanks for working on a PR.
The behaviour should in fact be the default one.

This will go into "quasar" v1.9.11.

@rstoenescu rstoenescu merged commit 3bc14b4 into quasarframework:dev Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.