From 50881b57f58564c70bea12e93fd9551d226a0c84 Mon Sep 17 00:00:00 2001 From: Mac Ryan Date: Thu, 26 May 2011 01:57:32 +0200 Subject: [PATCH] Partail code review (comments, tabs, indentation) --- .gitignore | 1 + config-erl.h | 10 +-- m168.h | 184 +++++++++++++++++++++++++-------------------------- makefile | 4 +- 4 files changed, 100 insertions(+), 99 deletions(-) diff --git a/.gitignore b/.gitignore index ca90aff..9d6ae2d 100644 --- a/.gitignore +++ b/.gitignore @@ -1,4 +1,5 @@ *~ +*.s *.sh *.o *.hex diff --git a/config-erl.h b/config-erl.h index ebe3acb..61beabc 100644 --- a/config-erl.h +++ b/config-erl.h @@ -2,13 +2,13 @@ ;; Matrix: ;; K L O C K A N X Ä R ;; 0 0 0 1 1 1 2 2 2 - ;; + ;; ;; X T J U G O F E M X ;; 3 3 3 4 4 5 5 5 - ;; + ;; ;; T I O K V A R T X I ;; 6 6 6 7 7 7 8 8 9 - ;; + ;; ;; X Ö V E R X H A L V ;; a a a b c c c d ;; @@ -23,7 +23,7 @@ ;; ;; S J U T O L V N I O ;;1a1a1a1b1b1b1c1d1d1d - ;; + ;; ;; Want structure to map minutes past the hour to strings to light ;; 0 -> ;; 1 -> 5, a, b @@ -37,7 +37,7 @@ ;; 9 -> 7, 8, 9 ;; 10-> 6, 9 ;; 11-> 5, 9 - + .equ NUMBER_TLC_CHIPS, 2 .global NUMBER_TLC_CHIPS diff --git a/m168.h b/m168.h index c005ef8..607d555 100644 --- a/m168.h +++ b/m168.h @@ -2,7 +2,7 @@ ;***** Created: 2010-02-25 11:46 ******* Source: ATmega168.xml *********** ;************************************************************************* ;* A P P L I C A T I O N N O T E F O R T H E A V R F A M I L Y -;* +;* ;* Number : AVR000 ;* File Name : "m168def.inc" ;* Title : Register/Bit Definitions for the ATmega168 @@ -10,27 +10,27 @@ ;* Version : 2.35 ;* Support E-mail : avr@atmel.com ;* Target MCU : ATmega168 -;* +;* ;* DESCRIPTION -;* When including this file in the assembly program file, all I/O register +;* When including this file in the assembly program file, all I/O register ;* names and I/O register bit names appearing in the data book can be used. -;* In addition, the six registers forming the three data pointers X, Y and -;* Z have been assigned names XL - ZH. Highest RAM address for Internal -;* SRAM is also defined -;* +;* In addition, the six registers forming the three data pointers X, Y and +;* Z have been assigned names XL - ZH. Highest RAM address for Internal +;* SRAM is also defined +;* ;* The Register names are represented by their hexadecimal address. -;* +;* ;* The Register Bit names are represented by their bit number (0-7). -;* +;* ;* Please observe the difference in using the bit names with instructions ;* such as "sbr"/"cbr" (set/clear bit in register) and "sbrs"/"sbrc" ;* (skip if bit in register set/cleared). The following example illustrates ;* this: -;* +;* ;* in r16,PORTB ;read PORTB latch ;* sbr r16,(1<