Skip to content

Commit

Permalink
Merge pull request #153 from elxa/fix-op-command-crashing-core
Browse files Browse the repository at this point in the history
Fixes a crash of the core when executing "/op *" in a query.
  • Loading branch information
Sput42 committed Nov 22, 2015
2 parents 1c9be12 + 476aaa0 commit b8edbda
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/core/coreuserinputhandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ void CoreUserInputHandler::doMode(const BufferInfo &bufferInfo, const QChar& add
if (!isNumber || maxModes == 0) maxModes = 1;

QStringList nickList;
if (nicks == "*") { // All users in channel
if (nicks == "*" && bufferInfo.type() == BufferInfo::ChannelBuffer) { // All users in channel
const QList<IrcUser*> users = network()->ircChannel(bufferInfo.bufferName())->ircUsers();
foreach(IrcUser *user, users) {
if ((addOrRemove == '+' && !network()->ircChannel(bufferInfo.bufferName())->userModes(user).contains(mode))
Expand Down

1 comment on commit b8edbda

@fgeek
Copy link

@fgeek fgeek commented on b8edbda Dec 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use CVE-2015-8547 for this issue.

Please sign in to comment.