Check if get was successful before trying to set some config. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@sinchb Can you also please publish the pyfoscam to PIP as an incremental version? I would prefer to pull it directly from PIP and add the latest version as dependency for easier maintenance of my home automation system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the set_motion_detection() function, the code is getting the current configuration, and then enabling/disabling the motion detection flag accordingly. The code is not checking if the get succeeded before trying to set the configuration.
Example, in a case where the foscam camera is not communicable, then if we try to give enable_motion_detection, then it will report an error that unable to set the "isEnable" flag etc.
This check fixes that error.