Path: listdir method to return directory entry names #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Main reason to wrap this is to able to unittest readdir in maven-tools with the mocked files |
stdweird
force-pushed
the
path_listdir
branch
3 times, most recently
from
0752cac
to
f8e8966
Compare
stdweird
force-pushed
the
path_listdir
branch
2 times, most recently
from
0d7586b
to
a242e77
Compare
ned21
requested changes
Jun 16, 2017
src/main/perl/FileWriter.pm
Outdated
| # Pass NoAction here, as it keeps track of the NoAction value during initialisation and/or keeps_state | ||
| my $cafpath = CAF::Path::mkcafpath(log => *$self->{LOG}, NoAction => $options->{noaction}); | ||
| # only create the directory if it didn't exist yet | ||
| # if not, this would for the directory mode on existing directories |
There was a problem hiding this comment.
This line doesn't make sense. "this would [what?] for the"
…r/readdir/closedir)
…to create the parent directory
ned21
approved these changes
Jun 17, 2017
|
@stdweird I thought I had seen that odd sentence before, and assumed I had just reviewed this PR before! |
|
@ned21 i added a new commit to this PR |
This was referenced Jun 19, 2017
jrha
approved these changes
Jun 20, 2017
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #243