Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCM::Format class to convert CCM instances in formatted text #55

Closed
wants to merge 14 commits into from

Conversation

stdweird
Copy link
Member

No description provided.

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/CCM-pr-builder/117/
Test FAILed.

@stdweird
Copy link
Member Author

Preparation for quattor/ncm-query#6 and for #43

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/CCM-pr-builder/118/
Test PASSed.

@stdweird stdweird added this to the 15.6 milestone May 18, 2015
@stdweird stdweird self-assigned this May 18, 2015
@ned21
Copy link
Contributor

ned21 commented May 28, 2015

I am afraid I don't really follow what this is for. Could commit ce7d814 provide some more detail as to why this is being added to the library? And then the POD for the library should say a bit more about how and when this it should be used.

@stdweird
Copy link
Member Author

@ned21 2 issues i'm trying to resolve: #43 and quattor/ncm-query#6
They both require to convert an Element instance (e.g. '/') to some well defined format (e.g. json).
So i made a new class to do just that.
But CCM::TextRender has become very powerful in the meanwhile, and if i was sure i could do all with CCM::TextRender, there is no need for a separate class anymore (at least for now the FORMATS_OTHER would be empty, and is a bit ugly).
The xml handling is the only thing that might be missing, and might require actual perl code; but it could be done i think (if it is to create pan xml profile format from an element instance, it's not that hard).

Usage is simple and similar to TextRender:

use EDG::WP4::CCM::Format;
my $el = $cfg->getElement("/");
$fmt = EDG::WP4::CCM::Format->new('json', $el);
print $fmt;

(but no ->filewriter support like TextRender).
But i'll update the pod.

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/CCM-pr-builder/130/
Test PASSed (test).

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/CCM-pr-builder/131/
Test PASSed (test).

@stdweird
Copy link
Member Author

@ned21 i managed to generate the panc xml output with TT, so no need for a separate module. i'll remove the Format.pm later; maybe i'll also make a new PR.

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/CCM-pr-builder/132/
Test PASSed (test).

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/CCM-pr-builder/137/
Test PASSed (test).

@stdweird stdweird closed this Jun 7, 2015
@stdweird
Copy link
Member Author

stdweird commented Jun 7, 2015

there will be no separate module, everything will come from CCM::TextRender

@stdweird
Copy link
Member Author

stdweird commented Jun 7, 2015

replaced by #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants