aii-opennebula: Include ONE labels support #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Labels are supported since ONE 5.x. This include labels support for VMs, templates and storage images. Resolves: quattor#224 See also: http://opennebula.org/opennebula-5-0-features-labels/
Fix error message when VM template is not available. Resolves: quattor#223
stdweird
reviewed
Nov 4, 2016
| @@ -171,4 +171,9 @@ type opennebula_vmtemplate = { | |||
| "diskcache" ? string with match(SELF, '^(default|none|writethrough|writeback|directsync|unsafe)$') | |||
| "permissions" ? opennebula_permissions | |||
| "pci" ? opennebula_vmtemplate_pci[] | |||
| @{labels is a string list to group the VMs under a given name and filter them | |||
| @@ -171,4 +171,9 @@ type opennebula_vmtemplate = { | |||
| "diskcache" ? string with match(SELF, '^(default|none|writethrough|writeback|directsync|unsafe)$') | |||
| "permissions" ? opennebula_permissions | |||
| "pci" ? opennebula_vmtemplate_pci[] | |||
| @{labels is a string list to group the VMs under a given name and filter them | |||
| in the admin and cloud views. It is also possible to include in the list | |||
| sub-labels using a common slash "Name, Name/SubName". This feature is available | |||
There was a problem hiding this comment.
example shoudl be pan code like list("Name", "Name/SubName")
|
minor remarks, LGTM otherwise |
|
@stdweird remarks addressed |
It was included RANDOM_PASS option by default to enhance console security Resolves: quattor#228
|
LGTM |
|
@jrha ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes new LABELS feature available since ONE 5.x