ncm-grub: Add support for configuring a console argument #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -86,6 +88,38 @@ sub Configure { | |||
| my $kernelversion=$config->getValue($kernelpath); | |||
| my $fulldefaultkernelpath=$prefix.'/'.$kernelname.'-'.$kernelversion; | |||
|
|
|||
| my $cons = undef; | |||
| my $consolepath = "/hardware/console/serial"; | |||
There was a problem hiding this comment.
is this part of the standard schema?
There was a problem hiding this comment.
It's not -- although that would be a separate patch to https://github.com/quattor/template-library-core/blob/master/quattor/schema.pan add it -- but it's an optional element so the code path is ignored if it's not present.
There was a problem hiding this comment.
please create the PR, but this should not be blocking this PR
There was a problem hiding this comment.
Configure a console argument if one is defined in /hardware/console.
piojo-zz
pushed a commit
that referenced
this pull request
May 5, 2014
ncm-grub: Add support for configuring a console argument
aka7
pushed a commit
to aka7/configuration-modules-core
that referenced
this pull request
Oct 14, 2022
…attor#163) * client/rpms: allow to disable ncm-cdispd/cdp-listend installation - Useful when Quattor is used to manage a VM image rather than a machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure a console argument if one is defined in /hardware/console.