Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry the restart of nscd up to 3 times #179

Merged
merged 4 commits into from Apr 3, 2014

Conversation

piojo-zz
Copy link
Member

nscd tends to crash, fail to restart... and all this is random. We try three times before giving up.

Fixes #175.

nscd tends to crash, fail to restart... and all this is random.  We try
three times before giving up.
$start->execute();
sleep(1);
if ($?) {
$self->warn("Failed attempt $i to restart nslcd");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo nslcd -> nscd

It may fail even if the daemon has started successfully
It was making the test fail at random.
@piojo-zz
Copy link
Member Author

@stdweird, fixed.

The last commit was breaking my tests at random, and I didn't want the PR builds to fail randomly as well.

I can move it to a different PR if needed.

@stdweird
Copy link
Member

looks ok (no need for other PR for the sssd test, it is a typo afterall)

ned21 added a commit that referenced this pull request Apr 3, 2014
Retry the restart of nscd up to 3 times
@ned21 ned21 merged commit 67b912e into quattor:master Apr 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ncm-authconfig-13.12 sometimes fails to stop/start nscd
3 participants