Plenary templates readme fixes and improvements #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use archetype/loadpath instead archetype/base - Missing ;
jrha
reviewed
May 29, 2018
|
I will wait for the aquilon PR to be finalised before looking at this too hard. |
jouvin
force-pushed
the
plenary_templates_readme
branch
from
d03cd97
to
39f1b7b
Compare
jrha
requested changes
Jul 30, 2018
jrha
force-pushed
the
plenary_templates_readme
branch
from
39f1b7b
to
21bda9f
Compare
jrha
force-pushed
the
plenary_templates_readme
branch
from
21bda9f
to
ad59f33
Compare
jrha
approved these changes
Dec 13, 2019
|
Updated to match code which was eventually merged into aquilon and documented config option that needs to be set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
;)loadpathto be consistent with the Aquilon PR in progressloadpathtemplateconfig/os/...expected by Aquilon as it requires the OS version which is normally defined there.