Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AII server configuration #37

Merged
merged 1 commit into from Apr 14, 2014
Merged

Fix AII server configuration #37

merged 1 commit into from Apr 14, 2014

Conversation

jouvin
Copy link
Contributor

@jouvin jouvin commented Apr 3, 2014

including use of ncm-aiiserver to configure aii-shellfe/dhcp

(includes JSON support)

@jouvin
Copy link
Contributor Author

jouvin commented Apr 13, 2014

Any comment? Else I'll merge it.

@ned21
Copy link
Contributor

ned21 commented Apr 13, 2014

Can you amend the commit message to describe what exactly is being fixed please? If the bug is already fully described in a github issue then you can say: "Fixes #[0-9]+" in the body of the log message to provide a link back to the issue.

@jouvin
Copy link
Contributor Author

jouvin commented Apr 13, 2014

In fact there is no corresponding issue opened... Just when trying to use it for our deployment server, I realized that what was in the template library was broken (not working at all). I can open an issue if you find it clearer. The end result of this PR should be that it just works as expected! (tested at GRIF)

@jouvin
Copy link
Contributor Author

jouvin commented Apr 13, 2014

Forgot to mention that this PR requires quattor/configuration-modules-core#184 to be merged.

@ned21
Copy link
Contributor

ned21 commented Apr 14, 2014

I am fine with not having an issue open but I can't review something for correctness if I don't have something that describes what "correct" looks like. :) So, if your headline is "Fix AII server configuration" then the body of the log message needs to describe what was broken and why this fixes it. Then the reviewer can assess whether you really have fixed it in the most optimal way. This also means that someone later who does a git blame knows why the code is implemented in this particular way.

Just in case you haven't come across this handy trick yet, you can rewrite an existing log message in git using: git commit --amend and then force push the branch.

@jouvin
Copy link
Contributor Author

jouvin commented Apr 14, 2014

Yes I know git commit --amend and use it everyday (may be too much)! I'll fix the commit message as suggested.

* Clean up the list of RPM installed for YUM-based deployment
* Properly integrate with sl5.x/6.x OS templates
* Use of ncm-aiiserver to configure aii-shellfe/dhcp
* JSON support
@jouvin
Copy link
Contributor Author

jouvin commented Apr 14, 2014

Commit message improved!

ned21 added a commit that referenced this pull request Apr 14, 2014
Fix AII server configuration
@ned21 ned21 merged commit b975a52 into quattor:master Apr 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants