New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Quay 3.8 EAP features #490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small comments from me to consider :)
0f85da1
to
81ef7fe
Compare
e7594ac
to
ece28c5
Compare
@stevsmit @HammerMeetNail Following two Quay 3.8.0 new features are not delivered to QE, so QE can review these parts once it's ready and tested. |
c815da0
to
8f9ac54
Compare
077ae4b
to
b77f9ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For proxy auto-pruning feature, could we also call out these:
- As part of auto-pruning, the tags marked for deletion are garbage collected eventually by garbage collector (gc) worker process. So the quota size restriction is not fully enforced during this period.
- the namespace quota size computation doesn't take into account the size for manifest child and is a known bug
b77f9ea
to
1a53b06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did a quick fly by. Most of the comments are just things to consider. Anything style guide related has a reference.
let me know if you have questions!
6caacc4
to
dea2a8c
Compare
Preview: https://stevsmit.github.io/quay-docs/eap7/