Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Quay 3.8 EAP features #490

Closed
wants to merge 2 commits into from
Closed

Conversation

stevsmit
Copy link
Member

@stevsmit stevsmit commented Aug 23, 2022

Copy link

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments from me to consider :)

early_access/master.adoc Show resolved Hide resolved
early_access/master.adoc Outdated Show resolved Hide resolved
modules/rn_3_80.adoc Outdated Show resolved Hide resolved
modules/rn_3_80.adoc Show resolved Hide resolved
modules/rn_3_80.adoc Outdated Show resolved Hide resolved
modules/rn_3_80.adoc Outdated Show resolved Hide resolved
modules/rn_3_80.adoc Show resolved Hide resolved
@stevsmit stevsmit force-pushed the eap-quay-38 branch 2 times, most recently from 0f85da1 to 81ef7fe Compare September 13, 2022 17:47
@stevsmit stevsmit force-pushed the eap-quay-38 branch 2 times, most recently from e7594ac to ece28c5 Compare September 14, 2022 21:02
@LiZhang19817
Copy link

LiZhang19817 commented Sep 15, 2022

@stevsmit @HammerMeetNail Following two Quay 3.8.0 new features are not delivered to QE, so QE can review these parts once it's ready and tested.

@stevsmit stevsmit force-pushed the eap-quay-38 branch 4 times, most recently from c815da0 to 8f9ac54 Compare September 20, 2022 19:14
@stevsmit stevsmit force-pushed the eap-quay-38 branch 3 times, most recently from 077ae4b to b77f9ea Compare September 23, 2022 15:06
Copy link

@harishsurf harishsurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For proxy auto-pruning feature, could we also call out these:

  1. As part of auto-pruning, the tags marked for deletion are garbage collected eventually by garbage collector (gc) worker process. So the quota size restriction is not fully enforced during this period.
  2. the namespace quota size computation doesn't take into account the size for manifest child and is a known bug

modules/testing-3-800.adoc Outdated Show resolved Hide resolved
Copy link

@michaelryanpeter michaelryanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a quick fly by. Most of the comments are just things to consider. Anything style guide related has a reference.

let me know if you have questions!

early_access/master.adoc Show resolved Hide resolved
modules/config-updates-38.adoc Outdated Show resolved Hide resolved
modules/config-updates-38.adoc Outdated Show resolved Hide resolved
modules/rn_3_80.adoc Outdated Show resolved Hide resolved
modules/rn_3_80.adoc Outdated Show resolved Hide resolved
modules/rn_3_80.adoc Outdated Show resolved Hide resolved
modules/rn_3_80.adoc Outdated Show resolved Hide resolved
modules/rn_3_80.adoc Outdated Show resolved Hide resolved
modules/rn_3_80.adoc Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants