Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sso: Add test for RHSSO OAuth service (PROJQUAY-2056) #1317

Merged
merged 1 commit into from May 11, 2022
Merged

sso: Add test for RHSSO OAuth service (PROJQUAY-2056) #1317

merged 1 commit into from May 11, 2022

Conversation

jonathankingfc
Copy link
Contributor

  • Add test for RHSSOOAuthService class

@jonathankingfc jonathankingfc force-pushed the add_unit_test branch 3 times, most recently from b4e4769 to a43fc1c Compare May 11, 2022 18:14
kleesc
kleesc requested changes May 11, 2022
View reviewed changes
oauth/loginmanager.py Outdated Show resolved Hide resolved
@jonathankingfc jonathankingfc force-pushed the add_unit_test branch 4 times, most recently from 0a6c66c to acddb61 Compare May 11, 2022 19:00
@jonathankingfc
sso: Add test for RHSSO OAuth service (PROJQUAY-2056)
245339e 
- Add test for RHSSOOAuthService class
kleesc
kleesc approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@kleesc kleesc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathankingfc jonathankingfc merged commit 2c3e26a into quay:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleesc kleesc kleesc approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@jonathankingfc @kleesc