lock: reuse redis client when creating locks (PROJQUAY-1872) #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleesc
force-pushed
the
reuse-redis-client-to-create-locks
branch
6 times, most recently
from
c0da241
to
c15d1e3
Compare
alecmerdler
reviewed
Apr 13, 2021
kleesc
force-pushed
the
reuse-redis-client-to-create-locks
branch
6 times, most recently
from
4e59fff
to
22ad0eb
Compare
By default, Redlock creates a new client per instance. Using the provided factory allows Redlock to reuse a single connection per instance and avoid running out of connections. e.g When a worker tries to get a lock, it should not open new connections every time. Increase sleep duration between queue polls on WorkerSleepException. This will give more time before retrying after failing to acquire a lock.
kleesc
force-pushed
the
reuse-redis-client-to-create-locks
branch
from
22ad0eb
to
68c0bf5
Compare
alecmerdler
approved these changes
Apr 14, 2021
kleesc
added a commit
to kleesc/quay
that referenced
this pull request
Apr 14, 2021
By default, Redlock creates a new client per instance. Using the provided factory allows Redlock to reuse a single connection per instance and avoid running out of connections. e.g When a worker tries to get a lock, it should not open new connections every time. Increase sleep duration between queue polls on WorkerSleepException. This will give more time before retrying after failing to acquire a lock.
kleesc
added a commit
that referenced
this pull request
Apr 14, 2021
…744) By default, Redlock creates a new client per instance. Using the provided factory allows Redlock to reuse a single connection per instance and avoid running out of connections. e.g When a worker tries to get a lock, it should not open new connections every time. Increase sleep duration between queue polls on WorkerSleepException. This will give more time before retrying after failing to acquire a lock.
syed
pushed a commit
to syed/quay
that referenced
this pull request
Apr 19, 2021
By default, Redlock creates a new client per instance. Using the provided factory allows Redlock to reuse a single connection per instance and avoid running out of connections. e.g When a worker tries to get a lock, it should not open new connections every time. Increase sleep duration between queue polls on WorkerSleepException. This will give more time before retrying after failing to acquire a lock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Redlock creates a new client per instance. Using the
provided factory allows Redlock to reuse a single connection per
instance and avoid running out of connections. e.g When a worker tries
to get a lock, it should not open new connections every time.
Increase sleep duration between queue polls on
WorkerSleepException. This will give more time before retrying after
failing to acquire a lock.