cache: remove GlobalLock from redis model cache (PROJQUAY-1902) #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove GlobalLock from Redis model cache implementation in favor of 'nx=True' when setting the key. Signed-off-by: Alec Merdler <alecmerdler@gmail.com>
kleesc
approved these changes
Apr 19, 2021
alecmerdler
added a commit
to alecmerdler/quay
that referenced
this pull request
Apr 20, 2021
…#755) Remove GlobalLock from Redis model cache implementation in favor of 'nx=True' when setting the key. Signed-off-by: Alec Merdler <alecmerdler@gmail.com>
alecmerdler
added a commit
that referenced
this pull request
Apr 20, 2021
#756) Remove GlobalLock from Redis model cache implementation in favor of 'nx=True' when setting the key. Signed-off-by: Alec Merdler <alecmerdler@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove GlobalLock from Redis model cache implementation in
favor of 'nx=True' when setting the key.
Signed-off-by: Alec Merdler alecmerdler@gmail.com