util: fix matching multiples in jsontemplate.py #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
I updated to fix the test and commit name (I think). Don't have a ticket ID so I added PROJQUAY-0000 |
kleesc
previously approved these changes
Jun 7, 2021
Matching multiples caused exceptions to be raised. This made it so
webhook notification POST bodies could not template things like the
image tags as `${tags[*]}`. This was caused by a typo in the jsonpath_rw
match field that was used.
Signed-off-by: Kalle Jillheden <kalle.jillheden@iver.se>
|
I'm super sorry for the failing tests. I've fixed them, yet again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching multiples caused exceptions to be raised. This made it so webhook notification POST bodies could not template things like the image tags as
${tags[*]}. This was caused by a typo in the jsonpath_rw match field that was used.I encountered this when trying to use the notification system in quay.io and decided to dig through the code to understand why it didn't work. I did not find a relevant Jira ticket about this, so I just created this PR without a Jira ticket.
Signed-off-by: Kalle Jillheden kalle.jillheden@iver.se