Skip to content

Qswap sc optimize#878

Merged
cyber-pc merged 8 commits into
qubic:developfrom
TakaYuPP:upgrade
May 19, 2026
Merged

Qswap sc optimize#878
cyber-pc merged 8 commits into
qubic:developfrom
TakaYuPP:upgrade

Conversation

@TakaYuPP
Copy link
Copy Markdown
Contributor

@TakaYuPP TakaYuPP commented May 14, 2026

  1. Reduce the state
  2. Optimize the procedures
  3. Fees

The migration tool is added here.
https://github.com/TakaYuPP/qubic-core-stateFile-migration-tool/tree/5d1bde8134df4c31731b7433f29725f611a5fb9b

Comment thread src/contracts/Qswap.h
Comment thread src/contracts/Qswap.h
Comment thread src/contracts/Qswap.h Outdated
Comment thread src/contracts/Qswap.h Outdated
@TakaYuPP
Copy link
Copy Markdown
Contributor Author

The migration tool has been added.

@TakaYuPP TakaYuPP requested a review from cyber-pc May 15, 2026 17:53
Copy link
Copy Markdown
Collaborator

@cyber-pc cyber-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relate to migration tool,

  • Just double check, QSWAP_INITIAL_MAX_POOL is changed and in your migration tool you truncate the last element of old pools, that mean if last elements existed you will remove them,https://github.com/TakaYuPP/qubic-core-stateFile-migration-tool/blob/3bd0aeeb8e971e86041e991c16d3eed17811d868/migration_tool.cpp#L1715-L1718 and https://github.com/TakaYuPP/qubic-core-stateFile-migration-tool/blob/3bd0aeeb8e971e86041e991c16d3eed17811d868/migration_tool.cpp#L1679-L1685

Also as I understand both this PR and #874 relate to the current QSwap's proposal https://github.com/javathon/Proposals/blob/d323fff406cdf0b760d341b378b5d88f5eff34e7/qswap-hardening.md , to get process further please make sure one migration tool work with both.

@TakaYuPP
Copy link
Copy Markdown
Contributor Author

Relate to migration tool,

  • Just double check, QSWAP_INITIAL_MAX_POOL is changed and in your migration tool you truncate the last element of old pools, that mean if last elements existed you will remove them,https://github.com/TakaYuPP/qubic-core-stateFile-migration-tool/blob/3bd0aeeb8e971e86041e991c16d3eed17811d868/migration_tool.cpp#L1715-L1718 and https://github.com/TakaYuPP/qubic-core-stateFile-migration-tool/blob/3bd0aeeb8e971e86041e991c16d3eed17811d868/migration_tool.cpp#L1679-L1685

Also as I understand both this PR and #874 relate to the current QSwap's proposal https://github.com/javathon/Proposals/blob/d323fff406cdf0b760d341b378b5d88f5eff34e7/qswap-hardening.md , to get process further please make sure one migration tool work with both.

we have two PRs regarding to the fee updates and state changes.
for now, we need to merge two PR as one. so please review and approve the #874 at first. then if the PR 874 is merged, I will pull and merge the updates to this PR. and I will create the final migration tool. Thank you.

@cyber-pc cyber-pc merged commit 545e2ba into qubic:develop May 19, 2026
2 checks passed
cyber-pc pushed a commit that referenced this pull request May 19, 2026
@TakaYuPP TakaYuPP mentioned this pull request May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants