Javascript #1

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@CruzR
CruzR commented Apr 23, 2012

The entries are generated via javascript. This allows to choose a source (currently oga, burningwell or wikimedia commons) via a select box.

@qubodup
Owner
qubodup commented Apr 23, 2012

I'm honored. :)

However, there are reasons against merging:

  1. The separation of categories requires the user to take additional action to be able to see all links. The intention of OST ist to give a simple window to existing textures on open sites. Having the menu makes it more complex to view the links/previews. I should clarify this in the readme.
  2. Your implementation makes the website useless when no JavaScript is available. There are ways to implement the functionality compatible with JS-less clients by using it to modify the existing HTML rather than using JS to generate it. It seems to me that being readable without JS is important for discovery (by search engines) and some very careful web users who disable client-side scripts (more common in the open source community I believe).

What is your intent with this change?

@CruzR
CruzR commented Apr 23, 2012

What is your intent with this change?

There are great resources on OpenGameArt.org, but there's also great stuff on BurningWell.org and on Wikimedia Commons. Currently, all but four links point to OGA. To allow the user to reach e.g. the brick textures on both OGA and burningwell, either the links have to explicitly point to each target, or there has to be some way to switch between the sources, and I thought the latter one might be nicer.

Your implementation makes the website useless when no JavaScript is available. There are ways to implement the functionality compatible with JS-less clients by using it to modify the existing HTML rather than using JS to generate it. It seems to me that being readable without JS is important for discovery (by search engines) and some very careful web users who disable client-side scripts (more common in the open source community I believe).

Ugh, your right, I didn't think about this. If I implement it in a way which still works for clients that don't have javascript enabled, would you be okay with merging it?

@CruzR
CruzR commented Apr 23, 2012

I'm closing this request and opening a new one.

@CruzR CruzR closed this Apr 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment