Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: usr: #260: Add metrics for cache available and download time #270

Merged
merged 7 commits into from Apr 3, 2019

Conversation

Projects
None yet
3 participants
@abhishekdas99
Copy link
Contributor

abhishekdas99 commented Mar 11, 2019

No description provided.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #270 into master will increase coverage by 0.17%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   50.51%   50.69%   +0.17%     
==========================================
  Files          60       60              
  Lines        3015     3026      +11     
  Branches      326      326              
==========================================
+ Hits         1523     1534      +11     
- Misses       1404     1405       +1     
+ Partials       88       87       -1
Impacted Files Coverage Δ
...ole/rubix/bookkeeper/FileDownloadRequestChain.java 84.53% <100%> (+0.49%) ⬆️
...va/com/qubole/rubix/bookkeeper/FileDownloader.java 91.93% <100%> (+0.26%) ⬆️
...qubole/rubix/common/metrics/BookKeeperMetrics.java 97.34% <100%> (+0.04%) ⬆️
...n/java/com/qubole/rubix/bookkeeper/BookKeeper.java 70.94% <60%> (+0.05%) ⬆️
.../qubole/rubix/hadoop2/Hadoop2ClusterManagerV2.java 54.38% <0%> (+1.75%) ⬆️

@abhishekdas99 abhishekdas99 requested review from jordanw-bq and kvankayala Mar 11, 2019

@@ -51,6 +51,7 @@
int diskReadBufferSize;
private MetricRegistry metrics;
private Counter totalMBDownloaded;
private Counter totalTimeToDownload;

This comment has been minimized.

Copy link
@kvankayala

kvankayala Mar 14, 2019

Collaborator

I think this totalTimeToDownload gives the cumulative value of total time spent in downloading all the data. How will this metric be useful to show any improvement in the query execution time or cache utilization ?

This comment has been minimized.

Copy link
@abhishekdas99

abhishekdas99 Mar 14, 2019

Author Contributor

This is useful to calculate the total time saved if data is read from the cache.

@abhishekdas99 abhishekdas99 merged commit fb0eadf into qubole:master Apr 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abhishekdas99 abhishekdas99 deleted the abhishekdas99:ISS-260 branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.