Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Something is up with Twitch embeds #129

Closed
raae opened this issue Oct 30, 2020 · 8 comments · Fixed by #137
Closed

Something is up with Twitch embeds #129

raae opened this issue Oct 30, 2020 · 8 comments · Fixed by #137
Assignees
@raae
Labels
bug Something isn't working help wanted Extra attention is needed released on @next released

Comments

@raae
Copy link
Member

raae commented Oct 30, 2020

They are not being embedded in the example sites, neither locally or on Netlify.
@raae raae added bug Something isn't working help wanted Extra attention is needed labels Oct 30, 2020
@raae
Copy link
Member Author

raae commented Nov 2, 2020 •
edited
Loading

v5 of Twitch API is deprecated and it seems v6 does not have oEmbed support.

See issues on the oEmbed repo: iamcal/oembed#437

@dpi
Copy link

dpi commented Nov 2, 2020

xpost https://discuss.dev.twitch.tv/t/oembed-deprecation/24424/3?u=dpi

@M0nica
Copy link

M0nica commented Nov 3, 2020

Should this plugin deprecate Twitch in light of this update from Twitch? It seems, from what I am reading, since their oEmbed functionality wasn’t publicly documented it was quietly deprecated on their end.

@raae
Copy link
Member Author

raae commented Nov 3, 2020 •
edited
Loading

The plugin uses the official list over on oembed.com, but it seems that Twitch should be removed from that list and then this project should remove all references to Twitch.

Just makes me so sad that oEmbed support is being dropped and I am holding out hoping it might be added back in...

But I guess you are right @M0nica and we should just go ahead and do it.

@raae
Copy link
Member Author

raae commented Nov 4, 2020

Would you like to do it @M0nica?

Add a PR for the removal of Twitch at https://github.com/iamcal/oembed and then add a notice in our docs.

@raae
Copy link
Member Author

raae commented Nov 5, 2020

I created a PR over in the oEmbed repo iamcal/oembed#495.

@raae raae self-assigned this Nov 5, 2020
@raae raae mentioned this issue Nov 5, 2020
Merged
@raae raae closed this as completed in #137 Nov 5, 2020
@raae-bot
Copy link

🎉 This issue has been resolved in version 0.2.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@raae-bot
Copy link

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raae raae

Labels
bug Something isn't working help wanted Extra attention is needed released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Readme update queen-raae/gatsby-remark-oembed
4 participants
@dpi @raae @M0nica @raae-bot