Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020.0 CI release : user option 'Allow custom item themes to override global theme' broken #226

Open
DeeTigIT opened this issue Dec 9, 2019 · 1 comment

Comments

@DeeTigIT
Copy link

@DeeTigIT DeeTigIT commented Dec 9, 2019

In the current 2020.0 CI release, the user option 'Allow custom item themes to override global theme = true' doesn't work correct anymore, see below.

I think this is could be regression, introduced with the new Tools, Options functionality. We had this bug in the past, namely, and it was fixed. Perhaps that fix is now (partially) overwritten by the new Tools, Options code that was merged some time ago into the CI?

If you compose a schedule with a custom item with it's own theme, then the override does work. However, if you save the schedule, start Quelea again and re-open the schedule, then the default theme is shown and the override doesn't work anymore.

This happens both for a schedule file with either:

  • Embedded media :
    I've checked the schedule internals: the media, that were used in setting up the custom item theme, are mentioned in the song xml AND are present in the 'resources' subfolder.
  • Linked media :
    I've checked the schedule internals: the media, that were used in setting up the custom item theme, are mentioned in the song xml.

So, although the item media are mentioned or present in the schedule, they don't override the default global theme anymore if the schedule is re-open in a new Quelea session.

We are using the 2019.0 cross platform release for production.
I've tested above with the latest 2020.0 CI cross platform.

@berry120

This comment has been minimized.

Copy link
Member

@berry120 berry120 commented Jan 25, 2020

This issue has been mentioned on Quelea community. There might be relevant details there:

https://quelea.discourse.group/t/custom-theme/336/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.