Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hue adjustment not working #8

Closed
berry120 opened this issue Jun 13, 2018 · 14 comments
Assignees

Comments

@berry120
Copy link
Member

@berry120 berry120 commented Jun 13, 2018

Hue adjustment doesn't seem to be working in 2018.1.

@berry120 berry120 self-assigned this Jun 13, 2018
@berry120

This comment has been minimized.

Copy link
Member Author

@berry120 berry120 commented Jun 20, 2018

This may be an issue with a library we're using (unless I'm missing something obvious, which is entirely possible.) It may be that something's also changed in VLC recently that means we need a different way of doing this.

caprica/vlcj#611

Will update as that ticket is updated.

@DeeTigIT

This comment has been minimized.

Copy link

@DeeTigIT DeeTigIT commented Sep 18, 2018

VLC 3.0.4 in combination with Q 2018.1 (and also the Q CI-release) has this hue issue.
But VLC 2.2.8 in combination with Q 2018.1 (and also the Q CI-release) doesn't seem to have this hue issue. Advice for the time being therefore: downgrade VLC to 2.2.8 when using Quelea 2018.1 or Quelea CI.

@berry120

This comment has been minimized.

Copy link
Member Author

@berry120 berry120 commented Jan 22, 2019

This should now be fixed in the CI release (fixed in VLCJ.) Issue was that VLC 3 changed their API for setting hue values.

@berry120 berry120 closed this in 9e26371 Jan 22, 2019
@DeeTigIT

This comment has been minimized.

Copy link

@DeeTigIT DeeTigIT commented Jan 26, 2019

@berry120

This comment has been minimized.

Copy link
Member Author

@berry120 berry120 commented Jan 26, 2019

@DeeTigIT

This comment has been minimized.

Copy link

@DeeTigIT DeeTigIT commented Jan 29, 2019

@berry120

This comment has been minimized.

Copy link
Member Author

@berry120 berry120 commented Jan 29, 2019

Oops, that'll teach me to try to fix something in a rush then run off... Another attempt at a fix pushed. I've actually made an effort to test it this time!

The hardware acceleration is a different issue but one we've had reported as well - the long and short of it is that the change / issue is with VLC, not Quelea. VLC 3 activates hardware accelerated decoding by default, whereas the 2.x branches had to have it enabled explicitly. I'm not aware of anything we can do to change this setting from within Quelea unfortunately.

@DeeTigIT

This comment has been minimized.

Copy link

@DeeTigIT DeeTigIT commented Jan 30, 2019

@berry120

This comment has been minimized.

Copy link
Member Author

@berry120 berry120 commented Jan 31, 2019

Thanks for confirming! Afraid I don't see that issue though - the hue seems to stay on for me for all subsequent repeats of the video. @ArvidNy - don't suppose you're able to reproduce that one?

@ArvidNy

This comment has been minimized.

Copy link
Member

@ArvidNy ArvidNy commented Jan 31, 2019

Sort of, but it's not working at all for me. I can set it and the preview looks alright, but the live window is using the default value right from the initial loop. Here's some debug info I got if that helps:

[00007faf2c2312c0] chain filter error: Too high level of recursion (3)
[00007faf2c165ca0] main filter error: Failed to create video converter
[00007faf2c2afe70] main filter error: Failed to create video converter
[00007faf18052190] main video output error: Failed to create video converter
[00007faf18052190] main video output error: Failed to compensate for the format changes, removing all filters
[00007faf0404f860] vdpau_avcodec generic error: Xlib is required for VDPAU
@berry120

This comment has been minimized.

Copy link
Member Author

@berry120 berry120 commented Jan 31, 2019

@ArvidNy

This comment has been minimized.

Copy link
Member

@ArvidNy ArvidNy commented Feb 1, 2019

Might be. @DeeTigIT, do you also use a Linux distro?

@DeeTigIT

This comment has been minimized.

Copy link

@DeeTigIT DeeTigIT commented Feb 1, 2019

@ArvidNy

This comment has been minimized.

Copy link
Member

@ArvidNy ArvidNy commented Feb 1, 2019

@berry120, I just read the javadoc for setHue and it states:

Video adjustments must be enabled for this to have any effect.

Just checked and isAdjustVideo returns false before we try to set the hue. I also checked setAdjustVideo which in turn states that:

The video adjustment controls must be enabled after the video has started playing.

Could the problem here be that adjustVideo is never successfully set after the video starts playing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.