Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme #84

Closed
Dazmed707 opened this issue Dec 23, 2018 · 7 comments
Closed

Dark theme #84

Dazmed707 opened this issue Dec 23, 2018 · 7 comments
Assignees
Milestone

Comments

@Dazmed707
Copy link

@Dazmed707 Dazmed707 commented Dec 23, 2018

Nose si para 2019.0 o 2019.1 se puede agregrar un tema global para quelea aparte de blanco, tema gris y negro.

@berry120

This comment has been minimized.

Copy link
Member

@berry120 berry120 commented Dec 23, 2018

Afraid I'm not sure what you're asking here - you can already add any new global theme you like?

@Dazmed707

This comment has been minimized.

Copy link
Author

@Dazmed707 Dazmed707 commented Dec 23, 2018

Yes, I like a skin dark/grey for quelea;
Ejemplo con OpenLP
Dark
imagen
White
imagen

@berry120

This comment has been minimized.

Copy link
Member

@berry120 berry120 commented Dec 29, 2018

Afraid this isn't something we're likely to add, as it's a huge amount of styling work and testing (and time is a bit of an issue at present!)

Certainly no objection to adding this in if anyone else wants to work on the stylesheet, so I'll leave it open in case someone wants to pick this up.

@berry120 berry120 changed the title Add new global theme Dark theme Jan 5, 2019
@berry120

This comment has been minimized.

Copy link
Member

@berry120 berry120 commented Jan 5, 2019

Note: Something like this may be worth investigating: https://github.com/joffrey-bion/javafx-themes

@ArvidNy

This comment has been minimized.

Copy link
Member

@ArvidNy ArvidNy commented Jan 8, 2019

I gave this an attempt and the result looks something like this. The changes are in a branch so that we could look at this closer for a future release.

dark-theme

@berry120

This comment has been minimized.

Copy link
Member

@berry120 berry120 commented Jan 8, 2019

Thanks Arvid! We'll take a more detailed look when 2019.0 is out.

@berry120 berry120 added this to the 2019.1 milestone Jan 8, 2019
@berry120

This comment has been minimized.

Copy link
Member

@berry120 berry120 commented Apr 25, 2019

Fixed in 2019.1.

@berry120 berry120 closed this Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.