New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment suggestions to GroupBy generics #1112

Closed
TuomasKiviaho opened this Issue Jan 9, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@TuomasKiviaho
Contributor

TuomasKiviaho commented Jan 9, 2015

Hi,

I noticed a slight discomfort in using generics while grouping.

GSum<T extends Number & Comparable<T>> could be just GSum<T extends Number>
GAvg<T extends Number & Comparable<T>> could be just GAvg<T extends Number>
GMin<T extends Comparable<T>> should beGMin<T extends Comparable<? super T>>
GMax<T extends Comparable<T>> should be GMax<T extends Comparable<? super T>>

The latter ones would actually be useful for me because I have to dumb down the generics in order to get things working (or typecast the date as java.util.Date)
GroupExpression<java.sql.Date, java.sql.Date> min = GroupBy.min((DatePath) date)

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Jan 11, 2015

Member

@TuomasKiviaho We are currently preparing to switch to a different package structure for the 4.0 release so it might be easier to do this change after that.

Member

timowest commented Jan 11, 2015

@TuomasKiviaho We are currently preparing to switch to a different package structure for the 4.0 release so it might be easier to do this change after that.

@timowest timowest added this to the 4.0.0 milestone Jan 22, 2015

@timowest timowest added the progress label Jan 28, 2015

@Shredder121 Shredder121 closed this in #1138 Jan 31, 2015

@timowest timowest removed the progress label Jan 31, 2015

@timowest timowest removed the progress label Mar 13, 2015

@timowest timowest modified the milestones: 3.6.3, 4.0.0 Mar 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment