Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSGi resolver issue with querydsl-sql-2.3.3.jar and javax.annotation #130

Closed
ctranxuan opened this issue Apr 17, 2012 · 2 comments
Closed

OSGi resolver issue with querydsl-sql-2.3.3.jar and javax.annotation #130

ctranxuan opened this issue Apr 17, 2012 · 2 comments

Comments

@ctranxuan
Copy link

@ctranxuan ctranxuan commented Apr 17, 2012

Hi,
I am currently testing Querydsl with Spring Data in a OSGi environment :

  • QueryDsl JPA 2.3.3
  • Virgo 3.0.2.RELASE
  • Java SDK 6

I get the following OSGi resolver stacktrace

Resolver report:
        An Import-Package could not be resolved. Caused by missing constraint in bundle <com.my-repository_0.0.1.BUILD-SNAPSHOT>
             constraint: <Import-Package: com.mysema.query.jpa; version="[2.3.3,3.0.0)">
        An Import-Package could not be resolved. Caused by missing constraint in bundle <com.mysema.querydsl.jpa_2.3.3>
             constraint: <Import-Package: com.mysema.query.sql; version="2.3.3">
        An Import-Package could not be resolved. Caused by missing constraint in bundle <com.mysema.querydsl.sql_2.3.3>
             constraint: <Import-Package: javax.annotation; version="1.3.2">

When I look at the MANIFEST.MF of querydsl-core-2.3.3.jar, there is an Import-Package javax.annotation;version="0" which looks fine. (idem with querydsl-jpa.jar)

But when I look at the MANIFEST.MF of querydsl-sql-2.3.3.jar, there is an Import-Package of javax.annotation;version="1.3.2" which is quite bad since the version number is inherited from the jar net.sourceforge.findbugs:jsr305:1.3.2 which is not OSGi compliant.

I guess the import of javax.annotation should be in version 0 in the querydsl-sql-2.3.3.jar as it is for the other jars.

Note also, there is an import javax.inject;version="0" while other bundles declares javax.inject;version="1".

Hope this help.

@timowest
Copy link
Member

@timowest timowest commented Apr 17, 2012

Replaced the two javax imports consistently with

javax.annotation;version="0"
javax.inject;version="0"

@timowest
Copy link
Member

@timowest timowest commented Apr 20, 2012

Released in 2.5.0

@timowest timowest closed this Apr 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants