Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify query class naming #186

Closed
timowest opened this issue Jun 29, 2012 · 2 comments
Closed

Unify query class naming #186

timowest opened this issue Jun 29, 2012 · 2 comments
Milestone

Comments

@timowest
Copy link
Member

@timowest timowest commented Jun 29, 2012

Query class and interface naming should be consistent in modules

Current state

Here is a list of query interfaces and classes in the Querydsl modules

Collections : ColQuery (interface) - ColQueryImpl
JPA : JPQLQuery (interface) - JPAQuery - HibernateQuery
JDO : JDOQLQuery (interface) - JDOQLQueryImpl
SQL : SQLQuery (interface) - SQLQueryImpl
Mongodb : MongodbQuery
Lucene : LuceneQuery - TypedQuery
Hibernate Search : SearchQuery

Sub queries:

JPA: JPASubQuery - HibernateSubQuery
SQL: SQLSubQuery

The Impl suffix usage in ColQueryImp, JDOQLQueryImpll and SQLQueryImpl differs from the rest.

Proposed changes

Remove Impl suffix

  • SQLQuery is removed and SQLQueryImpl is renamed to SQLQuery
  • ColQuery is removed and ColQueryImpl is renamed to CollQuery
  • JDOQLQueryImpl is renamed to JDOQuery
@timowest
Copy link
Member Author

@timowest timowest commented Dec 11, 2012

Here is the result

Collections : CollQuery
JPA : JPQLQuery (interface) - JPAQuery - HibernateQuery
JDO : JDOQLQuery (interface) - JDOQuery
SQL : SQLQuery
Mongodb : MongodbQuery
Lucene : LuceneQuery - TypedQuery
Hibernate Search : SearchQuery

Sub queries:

JPA: JPASubQuery - HibernateSubQuery
SQL: SQLSubQuery

The interface abstraction in the JPA module is used, since it provides two implementation with the same signature and also for JDO this abstraction might be useful for vendor specific customizations.

@timowest
Copy link
Member Author

@timowest timowest commented Jan 13, 2013

Released in 3.0.0.BETA1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant