Unify query class naming #186

Closed
timowest opened this Issue Jun 29, 2012 · 2 comments

Projects

None yet

1 participant

@timowest
Member

Query class and interface naming should be consistent in modules

Current state

Here is a list of query interfaces and classes in the Querydsl modules

Collections : ColQuery (interface) - ColQueryImpl
JPA : JPQLQuery (interface) - JPAQuery - HibernateQuery
JDO : JDOQLQuery (interface) - JDOQLQueryImpl
SQL : SQLQuery (interface) - SQLQueryImpl
Mongodb : MongodbQuery
Lucene : LuceneQuery - TypedQuery
Hibernate Search : SearchQuery

Sub queries:

JPA: JPASubQuery - HibernateSubQuery
SQL: SQLSubQuery

The Impl suffix usage in ColQueryImp, JDOQLQueryImpll and SQLQueryImpl differs from the rest.

Proposed changes

Remove Impl suffix

  • SQLQuery is removed and SQLQueryImpl is renamed to SQLQuery
  • ColQuery is removed and ColQueryImpl is renamed to CollQuery
  • JDOQLQueryImpl is renamed to JDOQuery
@timowest
Member

Here is the result

Collections : CollQuery
JPA : JPQLQuery (interface) - JPAQuery - HibernateQuery
JDO : JDOQLQuery (interface) - JDOQuery
SQL : SQLQuery
Mongodb : MongodbQuery
Lucene : LuceneQuery - TypedQuery
Hibernate Search : SearchQuery

Sub queries:

JPA: JPASubQuery - HibernateSubQuery
SQL: SQLSubQuery

The interface abstraction in the JPA module is used, since it provides two implementation with the same signature and also for JDO this abstraction might be useful for vendor specific customizations.

@timowest
Member

Released in 3.0.0.BETA1

@timowest timowest closed this Jan 13, 2013
@vbichov vbichov referenced this issue in spring-projects/spring-data-jdbc-ext May 6, 2013
Open

support for 3.x version of querydsl #2

@timowest timowest added this to the 3.0.0 milestone Apr 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment