New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uses the javax.annotation.Nullable from JSR305 but no dep available #226

Closed
rocketraman opened this Issue Sep 7, 2012 · 4 comments

Comments

Projects
None yet
2 participants
@rocketraman
Contributor

rocketraman commented Sep 7, 2012

querydsl-core class com.mysema.query.types.Expression references javax.annotation.Nullable, but the POM does not declare a dependency on it. This causes a problem when running downstream project tests since the Expression class cannot be loaded if the jsr305 stuff hasn't been pulled in from some other dependency.

Either a) the POM should include a dependency on com.google.code.findbugs/jsr305, or b) just get rid of the @Nullable annotations until it is standardized and part of the JVM. My recommended approach would be the latter... I can submit a pull request to this effect if you like.

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Sep 7, 2012

Member

guava has that dependency, is this an OSGI issue or do you have problems in a Maven build?

Member

timowest commented Sep 7, 2012

guava has that dependency, is this an OSGI issue or do you have problems in a Maven build?

@rocketraman

This comment has been minimized.

Show comment
Hide comment
@rocketraman

rocketraman Sep 11, 2012

Contributor

I had a problem with my Maven build, and now I understand why...

querydsl-core does not currently depend on findbugs/jsr305 directly, but transitively through Guava.

I have Guava in my own POM as a dependency, however, my Guava dependency has an exclusion on findbugs/jsr305. Therefore, my POM's guava dep overrides the querydsl-core guava dep, and so my project never got jsr305 as a dep. Thus I got compile errors when compiling code using the Expression class.

querydsl-core does have a direct dependency on jsr305 in the com.mysema.query.types.Expression class. So either the direct dependency should be removed or the dependency should be declared in the querydsl-core POM as a direct dependency. Either of these approaches would eliminate the corner case I saw with my build.

Contributor

rocketraman commented Sep 11, 2012

I had a problem with my Maven build, and now I understand why...

querydsl-core does not currently depend on findbugs/jsr305 directly, but transitively through Guava.

I have Guava in my own POM as a dependency, however, my Guava dependency has an exclusion on findbugs/jsr305. Therefore, my POM's guava dep overrides the querydsl-core guava dep, and so my project never got jsr305 as a dep. Thus I got compile errors when compiling code using the Expression class.

querydsl-core does have a direct dependency on jsr305 in the com.mysema.query.types.Expression class. So either the direct dependency should be removed or the dependency should be declared in the querydsl-core POM as a direct dependency. Either of these approaches would eliminate the corner case I saw with my build.

@rocketraman

This comment has been minimized.

Show comment
Hide comment
@rocketraman

rocketraman Sep 11, 2012

Contributor

PS I'm happy to submit a patch for either fix, but it is trivial.

Contributor

rocketraman commented Sep 11, 2012

PS I'm happy to submit a patch for either fix, but it is trivial.

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Sep 29, 2012

Member

Released in 2.8.0

Member

timowest commented Sep 29, 2012

Released in 2.8.0

@timowest timowest closed this Sep 29, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment