Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R2DBC support #2468

Open
mirromutth opened this issue Aug 2, 2019 · 13 comments · May be fixed by #2610
Open

R2DBC support #2468

mirromutth opened this issue Aug 2, 2019 · 13 comments · May be fixed by #2610

Comments

@mirromutth
Copy link

@mirromutth mirromutth commented Aug 2, 2019

R2DBC (Reactive Relational Database Connectivity) is for reactive programming and containing concise SPI. Looks like it will be very well integrated with the DSL-style frameworks.

See:


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@fzoli
Copy link

@fzoli fzoli commented Apr 13, 2020

@riba2101
Copy link

@riba2101 riba2101 commented Jun 4, 2020

So..its been almost a year, can we at least get an answer? will/wont do/prs accepted etc

@jwgmeligmeyling
Copy link
Member

@jwgmeligmeyling jwgmeligmeyling commented Jun 4, 2020

PR's will be accepted :) But no, this is not a priority of the core team.

@riba2101
Copy link

@riba2101 riba2101 commented Jun 4, 2020

wow that was fast, tnx man :)
Ok, will try to find time in the next month

@riba2101
Copy link

@riba2101 riba2101 commented Jun 4, 2020

@jwgmeligmeyling - for R2DBC we would need to bump the min version of java to 1.8, would that be ok?

@idosal
Copy link
Member

@idosal idosal commented Jun 4, 2020

@riba2101 Yes, it's on the roadmap for 5.0.

@jwgmeligmeyling
Copy link
Member

@jwgmeligmeyling jwgmeligmeyling commented Jun 4, 2020

Yes, and if you implement it in a dedicated module (querydsl-r2dbc) only that module has to be JDK8 afaik. So that also helps while the other modules are still on Java 7. But with 5.x we'll go to Java 8 anyway.

@riba2101
Copy link

@riba2101 riba2101 commented Jun 8, 2020

oh sry, was kinda busy - yeah that's how I've started and exactly how it's currently implemented, and yes, you are correct, a single module can have a different compile version

@riba2101
Copy link

@riba2101 riba2101 commented Jun 8, 2020

Hey guys, so...the changes are kinda huge...dunno how you guys wanna do this? (atm it's only compiling, need to test is extensively)

I would also like to point out that its heavily based on @fzoli s example

@riba2101 riba2101 linked a pull request that will close this issue Jun 8, 2020
@lpandzic
Copy link
Contributor

@lpandzic lpandzic commented Jan 16, 2021

If you want to use R2DBC with Querydsl now and are using Spring Data, Infobip Spring Data Querydsl now has R2DBC support.
Example usage:

interface TRepository extends ReactiveSortingRepository<T, ID>, ReactiveQuerydslPredicateExecutor<T>, QuerydslR2dbcFragment<T> {
}

QuerydslJdbcFragment provides access to SQLQuery, SQLUpdateClause and delete with Predicate support.

@j30ng
Copy link

@j30ng j30ng commented Mar 9, 2021

Hi all, when will #2610 be merged? Anything remains to be done?

@riba2101
Copy link

@riba2101 riba2101 commented Mar 9, 2021

Hi guys,

sorry I was really busy lately, will try to address the last comment shortly

@lpandzic
Copy link
Contributor

@lpandzic lpandzic commented Jun 16, 2021

5.0.0.M1 with Java 8 as baseline has been released so that addresses the #2468 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

7 participants