Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate off of jsr305 #2479

Closed
ptahchiev opened this issue Sep 27, 2019 · 3 comments · Fixed by #2674
Closed

Migrate off of jsr305 #2479

ptahchiev opened this issue Sep 27, 2019 · 3 comments · Fixed by #2674
Assignees
Projects
Milestone

Comments

@ptahchiev
Copy link

As discussed here:

google/guava#2960

and here:

spotbugs/spotbugs#180

JSR305 is dead and further more any jar that has classes in java or javax packages violates the Oracle JVM redistribution license.
Please use the spotbugs annotations instead.

@OrangeDog
Copy link

I'm not sure why it's needed at runtime for querydsl-core either. Should be e.g. provided.

@johnktims johnktims added this to To do in 5.x Nov 16, 2019
@jwgmeligmeyling
Copy link
Member

Some projects seem to migrate to https://github.com/JetBrains/java-annotations or https://github.com/typetools/checker-framework .

Guava hasn't decided yet.

Spotbugs decided to ship their own annotations.

A benefit of the Jetbrains java-annotations seem to be that they have CLASS retention. As a result we only require the dependency compile-time and it can have the provided scope, whereas with JSR305 is still required in compile scope.

@jwgmeligmeyling
Copy link
Member

Provided an implementation in #2674

jwgmeligmeyling added a commit that referenced this issue Oct 28, 2020
jwgmeligmeyling added a commit that referenced this issue Oct 28, 2020
jwgmeligmeyling added a commit that referenced this issue Oct 28, 2020
@jwgmeligmeyling jwgmeligmeyling moved this from To do to In progress in 5.x Dec 30, 2020
jwgmeligmeyling added a commit that referenced this issue Dec 31, 2020
5.x automation moved this from In progress to Done Dec 31, 2020
jwgmeligmeyling added a commit that referenced this issue Dec 31, 2020
@jwgmeligmeyling jwgmeligmeyling added this to the 5.0 milestone Jun 8, 2021
@jwgmeligmeyling jwgmeligmeyling self-assigned this Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5.x
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants