Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPAAnnotationProcessor produces uncompilable code #251

Closed
dusanmsk opened this issue Oct 19, 2012 · 4 comments
Closed

JPAAnnotationProcessor produces uncompilable code #251

dusanmsk opened this issue Oct 19, 2012 · 4 comments

Comments

@dusanmsk
Copy link

@dusanmsk dusanmsk commented Oct 19, 2012

Hi,

I am trying to migrate our legacy jpa2 project to querydsl, but can't compile generated Q-classes.

I tried to isolate a problem to simple example project:
https://docs.google.com/open?id=0B_7bCz1jc_1eQXJtMGI0VVA5VU0

Seems that querydsl parser has problem with:
public abstract class AbstractCatalog extends AbstractEntity {

... because removing T template ( public abstract class AbstractCatalog extends AbstractEntity )
compiles ok.

Is it possible to fix it?

Thank you.

@timowest
Copy link
Member

@timowest timowest commented Oct 19, 2012

Querydsl doesn't support raw usage of generic supertypes, you need to fix for example the following case

ChatMessagePrivacy extends AbstractCatalog

into this

ChatMessagePrivacy extends AbstractCatalog<CatalogCode>

or something comparable.

@timowest
Copy link
Member

@timowest timowest commented Oct 19, 2012

I will though make sure that generated classes will compile.

@dusanmsk
Copy link
Author

@dusanmsk dusanmsk commented Oct 19, 2012

Thx for fast response.

I've tried some quick refactoring and it seems that it was the point of the problem. I'll try to refactor all wrong declarations in our project on monday and we will see.

Have a nice weekend.

timowest added a commit that referenced this issue Oct 22, 2012
@timowest
Copy link
Member

@timowest timowest commented Oct 30, 2012

Released in 2.8.2

@timowest timowest closed this Oct 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants