New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test QueryDSL against Batoo JPA #265

Closed
hceylan opened this Issue Nov 3, 2012 · 10 comments

Comments

Projects
None yet
2 participants
@hceylan
Contributor

hceylan commented Nov 3, 2012

Hello,

We have a new JPA 2.0 implementation - Batoo JPA that implements the spec in full with the minimum possible diversion from the spec and the primary focus being on the best performance.

We have implemented a test case that suggests the basic functionality works.

I would kindly ask you to include Batoo JPA in your supported JPA backends.

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Nov 3, 2012

Member

Does Batoo JPA work without any compile time bytecode enhancement? That would make testing a bit more difficult.

Member

timowest commented Nov 3, 2012

Does Batoo JPA work without any compile time bytecode enhancement? That would make testing a bit more difficult.

@hceylan

This comment has been minimized.

Show comment
Hide comment
@hceylan

hceylan Nov 3, 2012

Contributor

As long as no serialization needed, build time instrumentation is not needed.

Contributor

hceylan commented Nov 3, 2012

As long as no serialization needed, build time instrumentation is not needed.

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Nov 3, 2012

Member

Do you mean as long as we don't persist anything it's ok? This sounds like it's needed in our tests. But I will take a closer look at Batoo JPA.

Member

timowest commented Nov 3, 2012

Do you mean as long as we don't persist anything it's ok? This sounds like it's needed in our tests. But I will take a closer look at Batoo JPA.

@hceylan

This comment has been minimized.

Show comment
Hide comment
@hceylan

hceylan Nov 3, 2012

Contributor

No, as long as the entity is not serialized out to the outside of the VM, that is not necessary. Hope this clarifies it.

Contributor

hceylan commented Nov 3, 2012

No, as long as the entity is not serialized out to the outside of the VM, that is not necessary. Hope this clarifies it.

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Nov 3, 2012

Member

Ok, thanks, that clarified it.

Member

timowest commented Nov 3, 2012

Ok, thanks, that clarified it.

timowest added a commit that referenced this issue Nov 5, 2012

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Nov 5, 2012

Member

Some issues I ran into

The last one is a blocker, since I don't want to move the annotations, the others are just inconveniences.

Member

timowest commented Nov 5, 2012

Some issues I ran into

The last one is a blocker, since I don't want to move the annotations, the others are just inconveniences.

@hceylan

This comment has been minimized.

Show comment
Hide comment
@hceylan

hceylan Nov 5, 2012

Contributor
  • No persistence.xml -> I have created an issue for that.
  • classpath scan -> the issue has just been resolved
  • Access Type, unless very complex, this should work. Nevertheless, an issue exists to resolve the ultimate uncertainity.

I will update the progress soon. The blocker should be resolved tomorrow as this is the only blocker bug to my knowledge. A release candidate will follow the issue's resolution.

Do you mind sharing the branch or the patch to enable Batoo JPA in QueryDSL?

Contributor

hceylan commented Nov 5, 2012

  • No persistence.xml -> I have created an issue for that.
  • classpath scan -> the issue has just been resolved
  • Access Type, unless very complex, this should work. Nevertheless, an issue exists to resolve the ultimate uncertainity.

I will update the progress soon. The blocker should be resolved tomorrow as this is the only blocker bug to my knowledge. A release candidate will follow the issue's resolution.

Do you mind sharing the branch or the patch to enable Batoo JPA in QueryDSL?

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Nov 5, 2012

Member

Wow, you're fast ;)

No persistence.xml -> I have created an issue for that.

I meant examples of how to use persistence.xml with jdbc parameters instead of a datasource. My settings worked, but there was a BoneCP error logging, so something went wrong.

classpath scan -> the issue has just been resolved

Nice

Access Type, unless very complex, this should work. Nevertheless, an issue exists to resolve the ultimate uncertainity.

I will use AccessType for now, but adding EmbeddedId in addition to the Id annotation to infer the access type would be a nice addition.

That basic integration has already been done in the commit referenced in this issue.

To enable the autodetection of Batoo JPA I need to know which class is returned by EntityManager.getDelegate()

Member

timowest commented Nov 5, 2012

Wow, you're fast ;)

No persistence.xml -> I have created an issue for that.

I meant examples of how to use persistence.xml with jdbc parameters instead of a datasource. My settings worked, but there was a BoneCP error logging, so something went wrong.

classpath scan -> the issue has just been resolved

Nice

Access Type, unless very complex, this should work. Nevertheless, an issue exists to resolve the ultimate uncertainity.

I will use AccessType for now, but adding EmbeddedId in addition to the Id annotation to infer the access type would be a nice addition.

That basic integration has already been done in the commit referenced in this issue.

To enable the autodetection of Batoo JPA I need to know which class is returned by EntityManager.getDelegate()

timowest added a commit that referenced this issue Nov 6, 2012

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Nov 6, 2012

Member

I had some exceptions on EntityManagerFactory startup due to configuration issues. Could you take a look?

You can for example setup Querydsl like this for Eclipse

mvn -Pjenkins,all eclipse:clean eclipse:eclipse
Member

timowest commented Nov 6, 2012

I had some exceptions on EntityManagerFactory startup due to configuration issues. Could you take a look?

You can for example setup Querydsl like this for Eclipse

mvn -Pjenkins,all eclipse:clean eclipse:eclipse

timowest added a commit that referenced this issue Nov 19, 2012

timowest added a commit that referenced this issue Nov 21, 2012

timowest added a commit that referenced this issue Nov 28, 2012

timowest added a commit that referenced this issue Dec 7, 2012

timowest added a commit that referenced this issue Feb 12, 2013

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Feb 20, 2013

Member

Released in 3.0.0.BETA2

Member

timowest commented Feb 20, 2013

Released in 3.0.0.BETA2

@timowest timowest closed this Feb 20, 2013

@timowest timowest added this to the 3.0.0 milestone Apr 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment