"mvn package" should just work #353

Closed
jendap opened this Issue Mar 7, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@jendap
Contributor

jendap commented Mar 7, 2013

I have some local changes I'd like to contribute but I can't really even build nor test querydsl easily.

So the first thing I'd like to contribute is maven changes. I'm better asking first as it's quite a lot of work so i you're not interested in merging it I rather won't do it.

Here's what I'd like to do - make " git clone ...querydsl...; mvn verify" works.

That involves following:

  1. enable repositories which are currently in "jenkins" profile by default
  2. make all the mssql, mysql, postgresql and oracle test Integrational Tests (running in phase verify). Only H2 and/or Derby would stay in phase "test" as no external dependencies are needed for those. The integration tests can be than disabled by "-DskipITs"
  3. move root pom to root directory (low priority)
  4. unify all dependency versions to the same (latest stable) versions using dependencyManagement in parent pom
  5. unify plugin settings in pluginManagement in parent

I've already done the integration tests refactoring. I'd like to do the rest but it's quite some work to do it for no use. Let me know if you're interested in merging it :-)

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Mar 7, 2013

Member
  1. enable repositories which are currently in "jenkins" profile by default

Using of repository entries is discouraged in Sonatype OSS, which is our distribution channel https://docs.sonatype.org/display/Repository/Sonatype+OSS+Maven+Repository+Usage+Guide

So I'd prefer to keep it as it is

  1. make all the mssql, mysql, postgresql and oracle test Integrational Tests (running in phase verify). Only H2 and/or Derby would stay in phase "test" as no external dependencies are needed for those. The integration tests can be than disabled by "-DskipITs"

Ok, but maybe the integration-test phase might be better, since this is not package verification.

  1. move root pom to root directory (low priority)

Not needed.

  1. unify all dependency versions to the same (latest stable) versions using dependencyManagement in parent pom

Could you elaborate?

  1. unify plugin settings in pluginManagement in parent

Ok.

Member

timowest commented Mar 7, 2013

  1. enable repositories which are currently in "jenkins" profile by default

Using of repository entries is discouraged in Sonatype OSS, which is our distribution channel https://docs.sonatype.org/display/Repository/Sonatype+OSS+Maven+Repository+Usage+Guide

So I'd prefer to keep it as it is

  1. make all the mssql, mysql, postgresql and oracle test Integrational Tests (running in phase verify). Only H2 and/or Derby would stay in phase "test" as no external dependencies are needed for those. The integration tests can be than disabled by "-DskipITs"

Ok, but maybe the integration-test phase might be better, since this is not package verification.

  1. move root pom to root directory (low priority)

Not needed.

  1. unify all dependency versions to the same (latest stable) versions using dependencyManagement in parent pom

Could you elaborate?

  1. unify plugin settings in pluginManagement in parent

Ok.

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Mar 14, 2013

Member

The most important remaining issue seems to be the categorization of jUnit tests to be able to skip tests which use external databases.

Member

timowest commented Mar 14, 2013

The most important remaining issue seems to be the categorization of jUnit tests to be able to skip tests which use external databases.

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Mar 21, 2013

Member

Released in 3.0.0

Member

timowest commented Mar 21, 2013

Released in 3.0.0

@timowest timowest closed this Mar 21, 2013

@timowest timowest added this to the 3.0.0 milestone Apr 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment