New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APT jar is not included on sql module bundle #478

Closed
luisfpg opened this Issue Aug 19, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@luisfpg

luisfpg commented Aug 19, 2013

The @QueryProjection and @QueryEntity annotations have their use cases among the sql module, because it is possible to have both constructor projection and bean projection with the .as(queryEntity.property) methods, so no strings are needed.

Hence, I'd expect the querydsl-apt-X.X.X.jar to be bundled with the sql zip file, at least with the sql-codegen file, but it is not.

This, however, is insufficient, as there is no jar with the META-INF/services/javax.annotation.processing.Processor file declaring the QuerydslAnnotationProcessor class, which is, for example, required by Eclipse. I managed to make it work by copying the jar from the querydsl-collections download and creating a jar with the aforementioned META-INF file.

It would be nice if querydsl-sql (and querydsl-collections for that matter) would have the same treatment as the jpa module, including something like lib/all/querydsl-apt-X.X.X.jar (same as the one in collections), lib/all/querydsl-sql-X.X.X-apt.jar (just with the META-INF/services/j.a.p.Processor) and something like lib/apt/querydsl-sql-X.X.X-sql-one-jar.jar, with all dependencies and metadata.

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Aug 21, 2013

Member

Maybe a separate zip packaging of the general APT functionality could be a better approach? Since SQL and the Collections module are not dependent on it, it might be confusing.

Could at querydsl-apt full deps packaging maybe fill this role? The querydsl-apt artifact has already the general classifier which has the processor metadata http://search.maven.org/#artifactdetails|com.mysema.querydsl|querydsl-apt|3.2.2|jar

Member

timowest commented Aug 21, 2013

Maybe a separate zip packaging of the general APT functionality could be a better approach? Since SQL and the Collections module are not dependent on it, it might be confusing.

Could at querydsl-apt full deps packaging maybe fill this role? The querydsl-apt artifact has already the general classifier which has the processor metadata http://search.maven.org/#artifactdetails|com.mysema.querydsl|querydsl-apt|3.2.2|jar

@luisfpg

This comment has been minimized.

Show comment
Hide comment
@luisfpg

luisfpg Aug 27, 2013

Yes, that would be fine... Indeed, the apt functionality could be reused by some modules (collections / sql), and those modules don't depend on each other.

luisfpg commented Aug 27, 2013

Yes, that would be fine... Indeed, the apt functionality could be reused by some modules (collections / sql), and those modules don't depend on each other.

@ghost ghost assigned timowest Aug 27, 2013

timowest added a commit that referenced this issue Aug 29, 2013

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Aug 29, 2013

Member

Now there is also a zip bundle for the apt module including a one-jar version for the GeneralAnnotationProcessor.

Member

timowest commented Aug 29, 2013

Now there is also a zip bundle for the apt module including a one-jar version for the GeneralAnnotationProcessor.

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Oct 20, 2013

Member

Released in 3.2.4

Member

timowest commented Oct 20, 2013

Released in 3.2.4

@timowest timowest closed this Oct 20, 2013

@timowest timowest added this to the 3.2.4 milestone Apr 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment