SQLQueryFactory.from() inconsistent with SQLQuery().from() #502

Closed
cowwoc opened this Issue Sep 10, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@cowwoc
Contributor

cowwoc commented Sep 10, 2013

This is an API design issue (which is a subjective topic). Feel free to ignore this issue if you disagree.

SQLQueryFactory.from() is supposed to be a shorthand for SQLQuery().from(), unfortunately the latter contains 3 methods whereas the former only covers the simple case (selecting data from a single table).

Consider adding the remaining methods to SQLQueryFactory or removing SQLQueryFactory.from() and letting users invoke SQLQueryFactory.query().from(...). I personally prefer the latter, but it implies breaking backwards compatibility.

timowest added a commit that referenced this issue Sep 10, 2013

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Oct 20, 2013

Member

Released in 3.2.4

Member

timowest commented Oct 20, 2013

Released in 3.2.4

@timowest timowest closed this Oct 20, 2013

@timowest timowest added this to the 3.2.4 milestone Apr 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment