Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide SQLBindings for AbstractSQLClause #534

Closed
BuBuaBu opened this issue Oct 29, 2013 · 2 comments
Closed

Provide SQLBindings for AbstractSQLClause #534

BuBuaBu opened this issue Oct 29, 2013 · 2 comments
Milestone

Comments

@BuBuaBu
Copy link

@BuBuaBu BuBuaBu commented Oct 29, 2013

few month ago, the getSQL(Expression<?>... exprs) method, for getting SQLBindings, has been added to AbstractSQLQuery class.

It would be interesting to get an equivalent method on all AbstractSQLClause. (SQLDeleteClause, SQLInsertClause, SQLUpdateClause, SQLMergeClause)

AbstractSQLClause support batch mode (addBatch()) so the bindings will be a little different.

We could have a getSQL() method returning a list of SQLBindings, one entry per batch.
Or an update SQLBindings. For example, SQLBindings could be an Iterable, and after each call to the next() method, the getBindings() would return values for the next available batch.

What do you think?
Will it be possible to integrate such change in QueryDSL?

@timowest
Copy link
Member

@timowest timowest commented Oct 29, 2013

Sounds like a good addition.

timowest added a commit that referenced this issue Oct 31, 2013
Improve param expression support
@timowest
Copy link
Member

@timowest timowest commented Nov 17, 2013

Released in 3.3.0.BETA1

@timowest timowest closed this Nov 17, 2013
@timowest timowest added this to the 3.3.0 milestone Apr 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants