Provide SQLBindings for AbstractSQLClause #534

Closed
BuBuaBu opened this Issue Oct 29, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@BuBuaBu

BuBuaBu commented Oct 29, 2013

few month ago, the getSQL(Expression<?>... exprs) method, for getting SQLBindings, has been added to AbstractSQLQuery class.

It would be interesting to get an equivalent method on all AbstractSQLClause. (SQLDeleteClause, SQLInsertClause, SQLUpdateClause, SQLMergeClause)

AbstractSQLClause support batch mode (addBatch()) so the bindings will be a little different.

We could have a getSQL() method returning a list of SQLBindings, one entry per batch.
Or an update SQLBindings. For example, SQLBindings could be an Iterable, and after each call to the next() method, the getBindings() would return values for the next available batch.

What do you think?
Will it be possible to integrate such change in QueryDSL?

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Oct 29, 2013

Member

Sounds like a good addition.

Member

timowest commented Oct 29, 2013

Sounds like a good addition.

timowest added a commit that referenced this issue Oct 31, 2013

Add getSQL for DML clauses #534
Improve param expression support
@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Nov 17, 2013

Member

Released in 3.3.0.BETA1

Member

timowest commented Nov 17, 2013

Released in 3.3.0.BETA1

@timowest timowest closed this Nov 17, 2013

@timowest timowest added this to the 3.3.0 milestone Apr 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment