Document Querydsl Roo support better #546

Closed
timowest opened this Issue Nov 12, 2013 · 5 comments

Comments

Projects
None yet
2 participants
@timowest
Member

timowest commented Nov 12, 2013

Document Querydsl Roo support better. The APT based approach works only if all the relevant data is on the source level (RooJpaEntity annotation and property declarations).

@bluezio

This comment has been minimized.

Show comment
Hide comment
@bluezio

bluezio Nov 12, 2013

I am the person who reported this on Twitter :-). I am a beginner on Roo and over the past few weeks I've built a data model for a small case study I'm doing for my PhD. I don't mind sharing it if it helps find out something. Shall I?

In short, I have a hierarchy of classes with @RooJpaEntity, some of which are extended with AspectJ ITDs. I don't really expect a source-based approach to pick up those ITDs, but it'd be nice if inheritance did work.

bluezio commented Nov 12, 2013

I am the person who reported this on Twitter :-). I am a beginner on Roo and over the past few weeks I've built a data model for a small case study I'm doing for my PhD. I don't mind sharing it if it helps find out something. Shall I?

In short, I have a hierarchy of classes with @RooJpaEntity, some of which are extended with AspectJ ITDs. I don't really expect a source-based approach to pick up those ITDs, but it'd be nice if inheritance did work.

@bluezio

This comment has been minimized.

Show comment
Hide comment
@bluezio

bluezio Nov 12, 2013

Let me revise that a bit: I have a few @RooJpaEntity classes, but many more use @RooJpaActiveRecord instead. Isn't RooJpaActiveRecord a superset of RooJpaEntity, as stated in the javadocs here?

https://github.com/spring-projects/spring-roo/blob/master/addon-jpa/src/main/java/org/springframework/roo/addon/jpa/activerecord/RooJpaActiveRecord.java

I created most of my classes with the usual Roo commands and most of them don't actually use RooJpaEntity but RooJpaActiveRecord instead.

bluezio commented Nov 12, 2013

Let me revise that a bit: I have a few @RooJpaEntity classes, but many more use @RooJpaActiveRecord instead. Isn't RooJpaActiveRecord a superset of RooJpaEntity, as stated in the javadocs here?

https://github.com/spring-projects/spring-roo/blob/master/addon-jpa/src/main/java/org/springframework/roo/addon/jpa/activerecord/RooJpaActiveRecord.java

I created most of my classes with the usual Roo commands and most of them don't actually use RooJpaEntity but RooJpaActiveRecord instead.

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Nov 13, 2013

Member

Ok, then at least one improvement on the APT side could be to support both RooJpaEntity and RooJpaActiveRecord.

Member

timowest commented Nov 13, 2013

Ok, then at least one improvement on the APT side could be to support both RooJpaEntity and RooJpaActiveRecord.

@bluezio

This comment has been minimized.

Show comment
Hide comment
@bluezio

bluezio Nov 13, 2013

Thanks, that would be great :-).

bluezio commented Nov 13, 2013

Thanks, that would be great :-).

timowest added a commit that referenced this issue Nov 16, 2013

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Nov 17, 2013

Member

Released in 3.3.0.BETA1

Member

timowest commented Nov 17, 2013

Released in 3.3.0.BETA1

@timowest timowest closed this Nov 17, 2013

@timowest timowest added this to the 3.3.0 milestone Apr 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment