Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPA API should be an optional dependency #654

Closed
odrotbohm opened this issue Feb 5, 2014 · 2 comments
Closed

JPA API should be an optional dependency #654

odrotbohm opened this issue Feb 5, 2014 · 2 comments
Milestone

Comments

@odrotbohm
Copy link

@odrotbohm odrotbohm commented Feb 5, 2014

The JPA module of Querydsl currently depends on the Hibernate provided JPA 2.0 API JAR in compile scope. Unfortunately this creates conflicts when you're using a Hibernate version that pulls in the JPA 2.1 JAR as the API JARs have the JPA version in their artifact names which prevents Maven's conflict resolution mechanism from working correctly. So you'll end up with both JARs on the classpath and the persistence provider potentially failing, depending on the order of them.

So I think it'd be better to make the API JAR an optional or provided dependency as it will be pulled in by the persistence provider anyway.

@timowest
Copy link
Member

@timowest timowest commented Feb 5, 2014

Fixed.

@timowest timowest added the fixed label Feb 5, 2014
@timowest
Copy link
Member

@timowest timowest commented Feb 8, 2014

Released in 3.3.1

@timowest timowest closed this Feb 8, 2014
@timowest timowest added this to the 3.3.1 milestone Apr 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants