no code generated for functions or types #661

Closed
khoran opened this Issue Feb 13, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@khoran

khoran commented Feb 13, 2014

Issue #338 has broken the generation of classes for table returning functions and user defined TYPEs (in postgres). There are more then just tables and views in the world of databases. Can you please add an option to return the original functionality of generating classes for everything? Thanks.

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Feb 13, 2014

Member

The JDBC table types are "TABLE", "VIEW", "SYSTEM TABLE", "GLOBAL TEMPORARY", "LOCAL TEMPORARY", "ALIAS", "SYNONYM".

I can provide additional export* options to add additional types beside "TABLE" and "VIEW". Which do you need?

How did you use these additional types? They are not officially supported.

Member

timowest commented Feb 13, 2014

The JDBC table types are "TABLE", "VIEW", "SYSTEM TABLE", "GLOBAL TEMPORARY", "LOCAL TEMPORARY", "ALIAS", "SYNONYM".

I can provide additional export* options to add additional types beside "TABLE" and "VIEW". Which do you need?

How did you use these additional types? They are not officially supported.

@khoran

This comment has been minimized.

Show comment
Hide comment
@khoran

khoran Feb 13, 2014

Well, I guess they just worked before as a happy accident then :). It seems the entities I'm looking for don't have a table type. If I leave the "types" field null in the call to "getTables", then I get the entities I want, and they have their "TABLE_TYPE" field (in the result set of "getTables") set to null. So it seems the only way to get them is to set the "types" field to null. Perhaps you can add an option like "exportAll" or something for this case.

The types I'm looking for are TYPE (http://www.postgresql.org/docs/9.0/static/sql-createtype.html) objects in PostgreSQL. They are used for table returning functions. I've been using them in version 2.7.1 for a while and they work just fine. I should add that in postgres, every existing table also has a corresponding TYPE object, but you can have TYPE objects with no corresponding table. Some functions return table-like data using TYPEs that do not correspond to any real table. It is these cases that are causing me trouble. For functions returning table data corresponding to a real table, then the Q class for that table can be used so there is no problem.

Thanks.

khoran commented Feb 13, 2014

Well, I guess they just worked before as a happy accident then :). It seems the entities I'm looking for don't have a table type. If I leave the "types" field null in the call to "getTables", then I get the entities I want, and they have their "TABLE_TYPE" field (in the result set of "getTables") set to null. So it seems the only way to get them is to set the "types" field to null. Perhaps you can add an option like "exportAll" or something for this case.

The types I'm looking for are TYPE (http://www.postgresql.org/docs/9.0/static/sql-createtype.html) objects in PostgreSQL. They are used for table returning functions. I've been using them in version 2.7.1 for a while and they work just fine. I should add that in postgres, every existing table also has a corresponding TYPE object, but you can have TYPE objects with no corresponding table. Some functions return table-like data using TYPEs that do not correspond to any real table. It is these cases that are causing me trouble. For functions returning table data corresponding to a real table, then the Q class for that table can be used so there is no problem.

Thanks.

timowest added a commit that referenced this issue Feb 14, 2014

@timowest timowest added the fixed label Feb 14, 2014

@khoran

This comment has been minimized.

Show comment
Hide comment
@khoran

khoran Feb 27, 2014

Great, thanks!

khoran commented Feb 27, 2014

Great, thanks!

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Mar 24, 2014

Member

Released in 3.3.2

Member

timowest commented Mar 24, 2014

Released in 3.3.2

@timowest timowest closed this Mar 24, 2014

@timowest timowest added this to the 3.3.2 milestone Apr 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment