typo in documentation: JPADeleteClause #693

Closed
e9827016 opened this Issue Apr 1, 2014 · 5 comments

Comments

Projects
None yet
3 participants
@e9827016

e9827016 commented Apr 1, 2014

The 2nd Example of JPAeDeleteClause contains a typo: JPAeDeleteClause => JPADeleteClause. Exact location see below.

http://www.querydsl.com/static/querydsl/3.3.2/reference/html/ch02.html#d0e349
2.1.11. Delete clauses

QCustomer customer = QCustomer.customer;
// delete all customers
new JPADeleteClause(entityManager, customer).execute();
// delete all customers with a level less than 3
new JPAeDeleteClause(entityManager, customer).where(customer.level.lt(3)).execute();

@e9827016 e9827016 changed the title from Minor documentation typo to typo in documentation Apr 1, 2014

@e9827016 e9827016 changed the title from typo in documentation to typo in documentation: JPADeleteClause Apr 1, 2014

@Shredder121

This comment has been minimized.

Show comment
Hide comment
@Shredder121

Shredder121 Apr 1, 2014

Member

Thanks for spotting it!

I have provided a pull request with your suggestion.

Member

Shredder121 commented Apr 1, 2014

Thanks for spotting it!

I have provided a pull request with your suggestion.

timowest added a commit that referenced this issue Apr 1, 2014

@timowest timowest added the fixed label Apr 1, 2014

@Shredder121

This comment has been minimized.

Show comment
Hide comment
@Shredder121

Shredder121 Apr 2, 2014

Member

Could someone close this issue now as it is resolved?

Member

Shredder121 commented Apr 2, 2014

Could someone close this issue now as it is resolved?

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Apr 2, 2014

Member

I'll close it when it's released. The fixed tag indicates that it is resolved. Issues are closed in Querydsl when they are released. Is that ok with you?

Member

timowest commented Apr 2, 2014

I'll close it when it's released. The fixed tag indicates that it is resolved. Issues are closed in Querydsl when they are released. Is that ok with you?

@Shredder121

This comment has been minimized.

Show comment
Hide comment
@Shredder121

Shredder121 Apr 2, 2014

Member

Oh yeah, that's right I forgot.
That's fine.

Member

Shredder121 commented Apr 2, 2014

Oh yeah, that's right I forgot.
That's fine.

@timowest timowest modified the milestone: 3.3.3 Apr 13, 2014

@timowest timowest modified the milestone: 3.3.3 Apr 30, 2014

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest May 2, 2014

Member

Released in 3.3.3

Member

timowest commented May 2, 2014

Released in 3.3.3

@timowest timowest closed this May 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment