MongodbSerializer unnecessarily calls getKeyForPath(…) #81

Closed
olivergierke opened this Issue Jan 12, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@olivergierke

As stated in a Spring Data forum post MongodbSerializer recursively calls visit(…) for any() path types passing an empty expression to the call. This results in getKeyForPath(…) being called with an empty expression which is actually not necessary as looking up a key for no expression hardly makes sense. Beyond that, potential subclasses have to deal with that case explicitly which complicates the implementation.

Long story short, the call to getKeyForPath(…) can be delayed into the else clause, avoiding that obsolete call.

timowest added a commit that referenced this issue Jan 12, 2012

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Feb 7, 2012

Member

released in 2.3.1

Member

timowest commented Feb 7, 2012

released in 2.3.1

@timowest timowest closed this Feb 7, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment