Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full join in JPA not allowed/useful #838

Closed
thackel opened this issue Jul 2, 2014 · 4 comments
Closed

full join in JPA not allowed/useful #838

thackel opened this issue Jul 2, 2014 · 4 comments
Milestone

Comments

@thackel
Copy link

@thackel thackel commented Jul 2, 2014

Using a JPAQuery allows to use query.fullJoin(...).

This is not defined in the JPA Specs and also Hibernate discourages the usage of its "full join" HQL expression.

So it should not be allowed to use this method, at least an exception could be thrown.

@timowest
Copy link
Member

@timowest timowest commented Jul 6, 2014

Full join is supported in HQL and from the reference docs I could only find the mentioning not usually useful that means that there are only few use cases where full join usage makes sense.

@timowest
Copy link
Member

@timowest timowest commented Aug 3, 2014

@thackel Would deprecation and removal in 4.0.0 maybe be reasonable?

@thackel
Copy link
Author

@thackel thackel commented Aug 4, 2014

I was just puzzled that i could build the query but the result was not as expected.
So a hint for the developer that .fullJoin() is not useful in JPA scenarios would be sufficient.
Use of deprecated methods is shown in most IDE's so its enough to identify a possible problem.

In terms of semantic versioning, i would not remove the method prior a major release (4.x).
So i am completely fine with your suggestion.

@timowest
Copy link
Member

@timowest timowest commented Aug 31, 2014

Released in 3.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.