New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full join in JPA not allowed/useful #838

Closed
thackel opened this Issue Jul 2, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@thackel

thackel commented Jul 2, 2014

Using a JPAQuery allows to use query.fullJoin(...).

This is not defined in the JPA Specs and also Hibernate discourages the usage of its "full join" HQL expression.

So it should not be allowed to use this method, at least an exception could be thrown.

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Jul 6, 2014

Member

Full join is supported in HQL and from the reference docs I could only find the mentioning not usually useful that means that there are only few use cases where full join usage makes sense.

Member

timowest commented Jul 6, 2014

Full join is supported in HQL and from the reference docs I could only find the mentioning not usually useful that means that there are only few use cases where full join usage makes sense.

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Aug 3, 2014

Member

@thackel Would deprecation and removal in 4.0.0 maybe be reasonable?

Member

timowest commented Aug 3, 2014

@thackel Would deprecation and removal in 4.0.0 maybe be reasonable?

@thackel

This comment has been minimized.

Show comment
Hide comment
@thackel

thackel Aug 4, 2014

I was just puzzled that i could build the query but the result was not as expected.
So a hint for the developer that .fullJoin() is not useful in JPA scenarios would be sufficient.
Use of deprecated methods is shown in most IDE's so its enough to identify a possible problem.

In terms of semantic versioning, i would not remove the method prior a major release (4.x).
So i am completely fine with your suggestion.

thackel commented Aug 4, 2014

I was just puzzled that i could build the query but the result was not as expected.
So a hint for the developer that .fullJoin() is not useful in JPA scenarios would be sufficient.
Use of deprecated methods is shown in most IDE's so its enough to identify a possible problem.

In terms of semantic versioning, i would not remove the method prior a major release (4.x).
So i am completely fine with your suggestion.

@timowest timowest added this to the 3.4.3 milestone Aug 6, 2014

@timowest timowest closed this in #885 Aug 9, 2014

@timowest

This comment has been minimized.

Show comment
Hide comment
@timowest

timowest Aug 31, 2014

Member

Released in 3.4.3

Member

timowest commented Aug 31, 2014

Released in 3.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment