Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPA templates using "like" need "escape" as well #87

Closed
djimenez opened this issue Jan 26, 2012 · 2 comments
Closed

JPA templates using "like" need "escape" as well #87

djimenez opened this issue Jan 26, 2012 · 2 comments

Comments

@djimenez
Copy link

@djimenez djimenez commented Jan 26, 2012

The querydsl-jpa unit tests don't cover using special characters _ or % in startsWith, contains, endsWith, etc. methods. When these are used, they are escaped, but the template doesn't include the escape clause which is necessary for the query to be valid and successful.

so two suggestions: add unit tests to cover these characters and add the escape to all templates that use like.

timowest added a commit that referenced this issue Jan 26, 2012
@timowest
Copy link
Member

@timowest timowest commented Jan 26, 2012

Thanks a lot for the fix!

@timowest
Copy link
Member

@timowest timowest commented Feb 7, 2012

released in 2.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants